Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global permissions are ignored with zero-command-permission #9

Closed
3ri4nG0ld opened this issue Apr 6, 2024 · 2 comments
Closed

Global permissions are ignored with zero-command-permission #9

3ri4nG0ld opened this issue Apr 6, 2024 · 2 comments
Labels
question Further information is requested

Comments

@3ri4nG0ld
Copy link

Until now I was using Lukyperms to manage permissions on my server, I have a Lobby created with paper and a mods server (in which I am using fuji), and both are connected with velocity.

On both servers and velocity I have installed Luckyperms configured in an external database.
This way all the permissions configured in velocity were applied in the rest of the servers, but when using zero-command-permission the permissions specified in velocity are ignored.

@sakurawald
Copy link
Owner

sakurawald commented Apr 6, 2024

Fuji works with luckperms.

For every command node, luckperms defines a tri-state permission predicate ("true", "false" and "undefined")

Zero-command-permission will iterate all the registered command-node and check if there is a relative zero-command defined for the command node. If there is, then we wrapper the original permission predicate with the zero-permission.

If there is no relative zero-permission for the command node, then we do nothing.
The permission predicate for the command node is never modified in this case.

See source: https://github.com/sakurawald/fuji-fabric/blob/1.20.4/src/main/java/io/github/sakurawald/module/initializer/zero_command_permission/ZeroCommandPermissionModule.java

Fuji check the permission by code Permissions.getPermissionValue, and it only contacts LuckPerms, never knows about velocity.
Maybe it's something about the permission sync between luckperms and velocity.

@sakurawald sakurawald added the question Further information is requested label Jun 2, 2024
@sakurawald
Copy link
Owner

Hello, can you check this #20 and let me know if this situation still exists ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants