Handle Ctrl/Shift + click on "Random item" button

[nmussy]

The "Random item" button doesn't act like a regular anchor with an href, and it's a little frustrating to have the current page be forcibly replaced.

You could add to your event listener support for the ctrlKey and shiftKey properties, to open the random item in a new tab, and a new window respectively:

discogs-enhancer/js/extension/features/random-item.js

Line 76 in 0c3f918

document.querySelector('.de-random-item').addEventListener('click', event => {

Still a pleasure to use your extension, thanks for the continued hard work 👍

[nmussy]

Oh, and it's a small nitpick, but I don't think "recycling" Unicode symbol is the clearest representation of a random element. I think either the gamedie (🎲) or twisted rightwards arrows(🔀) character would be easier for new users to understand

[salcido]

Hey @nmussy,

That's a good call, I can update that to a proper anchor so it can be opened in separate tags.

As for the icon, I initially wanted to use the twisted rightwards arrows but Chrome (or OS X, not sure which) automatically uses the Emoji version which does not match Discogs style guide. Personally, I don't think Emoji should represent UI elements, so I went with the recycling icon since it was a better match with Discogs' style guide aesthetics.

I may be able to use the Dice icon that is currently used in the React version of the Collection. I'll poke around a bit and see what I can come up with.

Thanks for the suggestions!

[nmussy]

Hey @salcido,

Yeah, I suggested looking at the event properties because it seemed simpler/more efficient than pre-rendering the anchor with the correct URL. But if you can manage it, it'd also fix the context menu "Open
in a new tab", "new window" etc.

And fair enough for the emoji forms, but you can always force the VS15 text variant by appending ︎ to the unicode character, e.g. 🎲︎

[salcido]

And fair enough for the emoji forms, but you can always force the VS15 text variant by appending ︎ to the unicode character, e.g. 🎲︎

TIL. That's pretty cool! I messed around a bit with that but still wasn't able to force the plain text version. Think I'll make an SVG of the twisted rightwards arrow icon as I like that a bit more than the gamedie.

While looking into this I realized Discogs has a specific URL just for random items so I'm able to simplify the script quite a bit and ditch the old async POST method I was using previously.

[nmussy]

That's unfortunate about the text varient, it works perfectly well on Chrome/Windows 10 :

And glad to hear about the random URL

[salcido]

Ok, just published an update to address this! Going to close this ticket ✌️

[nmussy]

Thanks!

…

On Wed, Jul 31, 2019, 1:46 AM Matthew Salcido ***@***.***> wrote: Ok, just published an update to address this! Going to close this ticket ✌️ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43?email_source=notifications&email_token=AATDXYDKSV4JZ5KTVSON44LQCDHFJA5CNFSM4IDR3EZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3FUH4A#issuecomment-516637680>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATDXYC2ITVQA5H2L7RIY7DQCDHFJANCNFSM4IDR3EZA> .