Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileAPL returns undefined if voluntary AuthData fields missing #299

Closed
djkato opened this issue Oct 25, 2023 · 0 comments · Fixed by #314
Closed

FileAPL returns undefined if voluntary AuthData fields missing #299

djkato opened this issue Oct 25, 2023 · 0 comments · Fixed by #314
Assignees
@lkostrowski
Labels
bug Something isn't working

Comments

@djkato
Copy link

djkato commented Oct 25, 2023

The domain field of AuthData is not mandatory (defined as (property) AuthData.domain?: string | undefined), and fileAPL should not return undefined if one of the voluntary fields are missing.

Fix:
src/APL/file-apl.ts:53

if (token && saleorApiUrl && appId) {
@lkostrowski lkostrowski added the bug Something isn't working label Nov 23, 2023
@lkostrowski lkostrowski mentioned this issue Dec 2, 2023
Merged
@lkostrowski lkostrowski self-assigned this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkostrowski lkostrowski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix file apl get saleor/app-sdk
2 participants
@lkostrowski @djkato