-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: dummy payment provider #484
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
e8f6ad6
to
4fde1d3
Compare
952f11e
to
9c8bcdb
Compare
After a conversation with @witoszekdev, I think the best way would be to include the Dummy Payment in the Dashboard configuration UI (same as the rest of the payment providers). I will add it tomorrow. |
dummy: { | ||
dummyKey: "", | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have this config? It looks like it's not used anywhere 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to the way the types are defined. I didn't find any easy way to change it, and I didn't want to change it drastically.
556f757
to
6a0b28d
Compare
80ab2e0
to
1cde27a
Compare
@witoszekdev merged your suggestion & rebased. Please approve & merge if all is good. |
@mmiszy please merge if all is good |
Features:
pages/api/dummy-pay.ts
- API endpoint for dummy payment (creates a transaction)dummy
into the existing structure (e.g.pages/api/pay.ts
)checkout-storefront/src/views/DummyPayment.tsx
view with a simple form that lets you pay either the entirety or a fraction of the order's total priceViews
component inRoot.tsx
, as there are now three views that can be displayed:Checkout
,OrderConfirmation
, andDummyPayment
.DummyPayment
's URL is:host/checkout?order=:orderId&dummyPayment=true
.Media:
Nagranie.z.ekranu.2022-09-30.o.14.19.20.mov
Questions:
IS_DUMMY_PROVIDER_ON
set tofalse
by default?