7.11.9 Release #8141

Dillon-Brown · 2019-10-28T14:23:05Z

Description

CF tag into master
Fixes auto-import cases failing to create a case due to trying to create a directory with no name.
Includes Resolve issue with email templates #8151
Includes Fix a SQL query in the ACLAction code. #8154
Includes Fixed MetaCest API test #8162

Motivation and Context

PHP Fatal error:  Uncaught RuntimeException: Directory "" was not created in /var/www/html/suitecrm-mysql/modules/InboundEmail/InboundEmail.php:4614
Stack trace:
#0 /var/www/html/suitecrm-mysql/modules/InboundEmail/InboundEmail.php(4514): InboundEmail->saveAttachmentBinaries(Object(Note), 109, '1.2', Object(stdClass), false)
#1 /var/www/html/suitecrm-mysql/modules/InboundEmail/InboundEmail.php(4444): InboundEmail->saveAttachments(109, Array, '71fe231b-5ea9-f...', 1, false)
#2 /var/www/html/suitecrm-mysql/modules/InboundEmail/InboundEmail.php(5314): InboundEmail->saveAttachments(109, Array, '71fe231b-5ea9-f...', '0', false)
#3 /var/www/html/suitecrm-mysql/modules/Schedulers/_AddJobsHere.php(636): InboundEmail->returnImportedEmail(109, 365, false, true, true)
#4 /var/www/html/suitecrm-mysql/modules/SchedulersJobs/SchedulersJob.php(540): pollMonitoredInboxesAOP(Object(SchedulersJob))
#5 /var/www/html/suitecrm-mysql/include/SugarQueue/SugarCronJobs.php(191): SchedulersJob->runJob()
#6 /var/www/html/suitecrm-mysql/include/SugarQueue/SugarCronJobs.php(231): SugarCronJobs->executeJob(Object(SchedulersJob in /var/www/html/suitecrm-mysql/modules/InboundEmail/InboundEmail.php on line 4614

How To Test This

Setup group inbound email.
Enable email -> cases.
If cron is not already setup, add root user to config allowed_cron_users and run php -f cron.php after sending a few emails to the group account.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

My code follows the code style of this project found here.
My change requires a change to the documentation.
I have read the How to Contribute guidelines.

…encoding # Conflicts: # composer.lock

# Conflicts: # .codecov.yml # codeception.yml # composer.lock # modules/Import/Importer.php

Hotfix merge

…ng hours check

The bean is cached anyway. I can't seem to get around that.

Common typo

PHP 5 is braindead. Type hinting a string will cause an error like this: "Argument 1 passed to GoogleSyncHelper::wipeLocalSyncData() must be an instance of string, string given" ... braindead...

Fix/htaccess

These changes fix issue salesagility#7926 The OAuth clients/tokens page has no widths defined, resulting in the totalWidth being 0, and so does the adjustment. The quickfix is to prevent dividing by the variable in such case, avoiding division by 0. When it does, we just set the final value to 0.

This change updates the .gitattributes to include several files in the list of files and directories to ignore when creating an archive. This allows us to download a ZIP of the repository without getting unncessary configuration files, CI related files, github specific files, etc.

This prevents the travis.php.ini file from being included in archives as it was missing the export-ignore flag. I've also fixed the php_cs.xml file as it was missing the .xml file extension.

This prevents the unified_search_modules_display file from being included in archives as it was missing the export-ignore flag.

Issue 6691

…ty-dividebyzero Hotfix: Do not divide by adjustment if it equals 0

Fixed salesagility#1504 - check deleted flag on email_addresses and related bean

Fixed ACLAction Travis failure

Compiling css and js files ahead of latest release.

…tfix

Merging hotfix-7.10.x into hotfix and recompiling in preparation for latest release.

craigpanton

LGTM

Mac-Rae · 2019-10-31T10:00:00Z

Assessed 👍

v7.11.9-cf # Conflicts: # modules/FP_events/FP_events.php

horus68 · 2019-10-31T14:09:16Z

modules/Emails/language/en_us.lang.php

    'LBL_MY_EMAILS' => 'Emails',
    'LBL_NEW_FORM_TITLE' => 'Archive Email',
    'LBL_NONE' => 'None',
    'LBL_NOT_SENT' => 'Send Error',
-    'LBL_NOTES_SUBPANEL_TITLE' => 'Attachments',
+    'LBL_NOTES_SUBPANEL_TITLE' => 'Attachments','LBL_MODULE_TITLE' => 'Emails:',


Error here! @Dillon-Brown

Thanks! removed.

…teCRM into fix/email_cache

Dillon-Brown and others added 30 commits September 30, 2019 11:07

Update composer.lock

91080d0

Merge remote-tracking branch 'upstream/hotfix-7.10.x' into fix/email_…

d5df53e

…encoding # Conflicts: # composer.lock

Merge remote-tracking branch 'upstream/hotfix-7.10.x' into hotfix

d3e68b9

# Conflicts: # .codecov.yml # codeception.yml # composer.lock # modules/Import/Importer.php

Update composer.lock

c730cb9

Fixed typo

5a352e8

Fix salesagility#7942 add bool to eligible fields for merging

80d3f00

Merge pull request salesagility#7941 from Dillon-Brown/hotfix_merge_19

1e5d72a

Hotfix merge

Fix salesagility#3129 Use correct Business Hours field name for openi…

ada0bcb

…ng hours check

Removed outdated RewriteRule

4725475

Fix for salesagility#7312

8673f13

remove unused variable

0ab1ba7

Test the new helper function

82a492b

Direct DB testing instead of using beans

5504f00

The bean is cached anyway. I can't seem to get around that.

Fix language key

b06945e

Fix class name

896d380

Use 'quoted' not 'quote'

da66dea

Common typo

Fix test. Need to properly quote the query string variable.

972ddaa

Kick Travis

0a8b7fb

Can't type hint strings in php5

0936c93

PHP 5 is braindead. Type hinting a string will cause an error like this: "Argument 1 passed to GoogleSyncHelper::wipeLocalSyncData() must be an instance of string, string given" ... braindead...

Merge pull request salesagility#7909 from Dillon-Brown/fix/htaccess

420f10d

Fix/htaccess

Fix language key

879cb8f

Fix class name

56a82fb

Recompile minified style.css

4e43e3f

Updated the .gitattributes export-ignore list

a60cd9c

This prevents the travis.php.ini file from being included in archives as it was missing the export-ignore flag. I've also fixed the php_cs.xml file as it was missing the .xml file extension.

Updated the .gitattributes export-ignore list

b535e09

This prevents the unified_search_modules_display file from being included in archives as it was missing the export-ignore flag.

Fix salesagility#7953 - Elasticsearch default query size setting

d1ec066

Merge pull request salesagility#7947 from ognjen-petrovic/issue-6691

2b5313d

Issue 6691

Merge pull request salesagility#7950 from Kishlin/hotfix-listviewsmar…

e9ccdc8

…ty-dividebyzero Hotfix: Do not divide by adjustment if it equals 0

craigpanton and others added 5 commits October 24, 2019 11:41

Merge pull request salesagility#8082 from grahambrown11/bugfix_1504

affe8fb

Fixed salesagility#1504 - check deleted flag on email_addresses and related bean

Merge pull request salesagility#8119 from Dillon-Brown/fix/travis_8

0262a79

Fixed ACLAction Travis failure

Merge pull request salesagility#8112 from craigpanton/hotfix-7.10.x

eab84c1

Compiling css and js files ahead of latest release.

Merge remote-tracking branch 'remotes/upstream/hotfix-7.10.x' into ho…

12cb302

…tfix

Merge pull request salesagility#8116 from craigpanton/hotfix

da19873

Merging hotfix-7.10.x into hotfix and recompiling in preparation for latest release.

craigpanton approved these changes Oct 28, 2019

View reviewed changes

Dillon-Brown changed the base branch from hotfix-7.10.x to master October 31, 2019 09:55

Fixed missing cache directory throwing RunTimeException

2707bc9

Dillon-Brown force-pushed the fix/email_cache branch from 59664e1 to 2707bc9 Compare October 31, 2019 09:58

Mac-Rae added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Oct 31, 2019

Mac-Rae and others added 2 commits October 31, 2019 10:12

Resolve issue with email templates

8ae00dc

Merge tag 'v7.11.9-cf' into fix/email_cache

9abd6ec

v7.11.9-cf # Conflicts: # modules/FP_events/FP_events.php

Dillon-Brown changed the title ~~Fixed missing cache directory throwing RunTimeException~~ 7.11.9 Release Oct 31, 2019

Fix a SQL query in the ACLAction code.

6999663

Dillon-Brown removed the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Oct 31, 2019

Dillon-Brown and others added 4 commits October 31, 2019 10:36

Fixed ACLActions issue

fee0795

Increment suitecrm_version

17ea7de

Update files.md5

f4e5339

Update suitecrm_version.php

1065efc

craigpanton approved these changes Nov 1, 2019

View reviewed changes

Updating release timestamp

1929411

horus68 reviewed Nov 4, 2019

View reviewed changes

Dillon-Brown and others added 6 commits November 4, 2019 13:31

Fixed MetaCest API test

c08ec2a

Fixed DBManager->db being called statically

0c44f99

Update AccountTest

975b5fa

Fixed EmailTest calling DBManager statically

a3f5373

Merge branch 'fix/email_cache' of https://github.com/Dillon-Brown/Sui…

8c90bdc

…teCRM into fix/email_cache

Removed duplicate language string

54a2f0a

craigpanton merged commit c9d2132 into salesagility:master Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7.11.9 Release #8141

7.11.9 Release #8141

Dillon-Brown commented Oct 28, 2019 •

edited

Loading

craigpanton left a comment

Mac-Rae commented Oct 31, 2019

horus68 Oct 31, 2019

Dillon-Brown Nov 4, 2019

7.11.9 Release #8141

7.11.9 Release #8141

Conversation

Dillon-Brown commented Oct 28, 2019 • edited Loading

Description

Motivation and Context

How To Test This

Types of changes

Final checklist

craigpanton left a comment

Choose a reason for hiding this comment

Mac-Rae commented Oct 31, 2019

horus68 Oct 31, 2019

Choose a reason for hiding this comment

Dillon-Brown Nov 4, 2019

Choose a reason for hiding this comment

Dillon-Brown commented Oct 28, 2019 •

edited

Loading