Skip to content

Commit

Permalink
fix: make Best work with Node v16
Browse files Browse the repository at this point in the history
* Update the `engines` values in `package.json` to allow Node v16.

* Change `runner-remote`'s socket options so to prevent "Unable to
  load PFX certificate" errors.

  This is a temporary fix meant to unblock users using Node v16.
  • Loading branch information
sf-v committed Apr 7, 2022
1 parent 62aaad2 commit 563cee2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"docs"
],
"engines": {
"node": ">=14.15.4 <15.0.0",
"node": ">=14.15.4 <17.0.0",
"yarn": ">=1.22.0 <2.0.0"
},
"volta": {
Expand Down
3 changes: 2 additions & 1 deletion packages/@best/runner-remote/src/runner-remote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export class RunnerRemote {
...options,
specs: JSON.stringify(specs),
jobs: benchmarksBuilds.length
}
},
pfx: []
};

if (token) {
Expand Down

0 comments on commit 563cee2

Please sign in to comment.