Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix className types in engine-core #4104

Open
nolanlawson opened this issue Mar 27, 2024 · 0 comments
Open

Fix className types in engine-core #4104

nolanlawson opened this issue Mar 27, 2024 · 0 comments
Labels
enhancement typescript Typescript related bugs Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

If you set a breakpoint in this function:

export function getMapFromClassName(className: string | undefined): Record<string, boolean> {

and run the Karma tests, you'll find that className can be a string, null, undefined, a number... Lots of things. But TypeScript thinks it can only be a string or undefined. We should fix these types to reflect reality.

@nolanlawson nolanlawson added enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation typescript Typescript related bugs labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement typescript Typescript related bugs Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

1 participant