fix(aom): consolidating the aria dom property names #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Mar 29, 2018
| @@ -79,15 +79,13 @@ describe('def', () => { | |||
| accessKey: null, | |||
| ariaActiveDescendant: null, | |||
| ariaAtomic: null, | |||
| ariaAutocomplete: null, | |||
| ariaAutoComplete: null, | |||
caridy
commented
Mar 29, 2018
| ariaBusy: null, | ||
| ariaChecked: null, | ||
| ariaControls: null, | ||
| ariaCurrent: null, | ||
| ariaDescribedBy: null, | ||
| ariaDisabled: null, | ||
| ariaDragged: null, |
There was a problem hiding this comment.
aria-grabbed, this seems like a typo in the first place.
and aria-dropeffect are deprecated by spec.
caridy
commented
Mar 29, 2018
| @@ -98,12 +96,12 @@ describe('def', () => { | |||
| ariaLevel: null, | |||
| ariaLive: null, | |||
| ariaMultiSelectable: null, | |||
| ariaMultiline: null, | |||
| ariaMultiLine: null, | |||
caridy
commented
Mar 29, 2018
| ariaOrientation: null, | ||
| ariaOwns: null, | ||
| ariaPosInSet: null, | ||
| ariaPressed: null, | ||
| ariaReadonly: null, | ||
| ariaReadOnly: null, |
caridy
commented
Mar 29, 2018
| @@ -113,6 +111,17 @@ describe('def', () => { | |||
| ariaValueMin: null, | |||
| ariaValueNow: null, | |||
| ariaValueText: null, | |||
| ariaColCount: null, | |||
There was a problem hiding this comment.
all these were missing.
|
@ekashida does this affects the interop? I suspect that it does since they have a copy of this list. |
Benchmark comparisonBase commit:
|
ekashida
approved these changes
Mar 29, 2018
|
Created a PR with the updates for interop. |
Benchmark comparisonBase commit:
|
|
@byao @davidturissini @pmdartus we might want to port this into the release branch today. |
diervo
pushed a commit
that referenced
this pull request
Mar 30, 2018
svc-aura
pushed a commit
to forcedotcom/aura
that referenced
this pull request
Apr 4, 2018
caridy
added a commit
that referenced
this pull request
May 2, 2018
* refactor(engine): avoid rewrapping of proxies * refactor(engine): prevent leaking double proxies via events or querySelector fix(aom): consolidating the aria dom property names (#192) wip: Remove slotting refactor(engine): conditinally use of native shadowRoot fix(engine): compat should also work with artificial shadow refactor(engine): adding slotting refactor(engine): adding slotting refactor(engine): conditionally piercing and default behaviors refactor(engine): minimizing the polyfilling on shadow-root to only AOM refactor(engine): implementing Pierre's suggestion to avoid patching shadow root prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alignment with spec changes:
w3c/aria#708
Does this PR introduce a breaking change?
It changes a little bit the names of the Aria DOM Properties, and add few missing properties. This only affects folks who are either using any of the 3 changed properties in templates, or are trying to redefine them with get/set. The 3 properties are
ariaAutoComplete,ariaMultiLineandariaReadOnly.Additionally, 2 deprecated properties were removed:
ariaDragged(which had a typo anyway) andariaDropEffect.