-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aom): consolidating the aria dom property names #192
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,15 +79,13 @@ describe('def', () => { | |
accessKey: null, | ||
ariaActiveDescendant: null, | ||
ariaAtomic: null, | ||
ariaAutocomplete: null, | ||
ariaAutoComplete: null, | ||
ariaBusy: null, | ||
ariaChecked: null, | ||
ariaControls: null, | ||
ariaCurrent: null, | ||
ariaDescribedBy: null, | ||
ariaDisabled: null, | ||
ariaDragged: null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
ariaDropEffect: null, | ||
ariaExpanded: null, | ||
ariaFlowTo: null, | ||
ariaHasPopUp: null, | ||
|
@@ -98,12 +96,12 @@ describe('def', () => { | |
ariaLevel: null, | ||
ariaLive: null, | ||
ariaMultiSelectable: null, | ||
ariaMultiline: null, | ||
ariaMultiLine: null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Casing was off! |
||
ariaOrientation: null, | ||
ariaOwns: null, | ||
ariaPosInSet: null, | ||
ariaPressed: null, | ||
ariaReadonly: null, | ||
ariaReadOnly: null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Casing was off! |
||
ariaRelevant: null, | ||
ariaRequired: null, | ||
ariaSelected: null, | ||
|
@@ -113,6 +111,17 @@ describe('def', () => { | |
ariaValueMin: null, | ||
ariaValueNow: null, | ||
ariaValueText: null, | ||
ariaColCount: null, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all these were missing. |
||
ariaColIndex: null, | ||
ariaDetails: null, | ||
ariaErrorMessage: null, | ||
ariaKeyShortcuts: null, | ||
ariaModal: null, | ||
ariaPlaceholder: null, | ||
ariaRoleDescription: null, | ||
ariaRowCount: null, | ||
ariaRowIndex: null, | ||
ariaRowSpan: null, | ||
dir: null, | ||
draggable: null, | ||
hidden: null, | ||
|
@@ -124,7 +133,7 @@ describe('def', () => { | |
}); | ||
}); | ||
|
||
it('should provide default html props', () => { | ||
it('should provide definition for each individual html prop', () => { | ||
function foo() {} | ||
class MyComponent extends Element {} | ||
const { props } = target.getComponentDef(MyComponent); | ||
|
@@ -140,7 +149,7 @@ describe('def', () => { | |
attr: 'role', | ||
}); | ||
// aria exception | ||
expect(props.ariaAutocomplete).toEqual({ | ||
expect(props.ariaAutoComplete).toEqual({ | ||
config: 3, | ||
type: 'any', | ||
attr: 'aria-autocomplete', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Casing was off!