Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark smoke tests should pin the chromedriver and Chrome versions #3852

Closed
nolanlawson opened this issue Nov 13, 2023 · 0 comments · Fixed by #3897
Closed

Benchmark smoke tests should pin the chromedriver and Chrome versions #3852

nolanlawson opened this issue Nov 13, 2023 · 0 comments · Fixed by #3897
Labels
ci tests Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Collaborator

nolanlawson commented Nov 13, 2023 •
edited
Loading

All versions of Chrome and Chromedriver should be pinned so that we aren't broken when Chrome does a release every 6 weeks.

As of #3847, the Chrome version is pinned, but not the Chromedriver version – it is evergreen.
@nolanlawson nolanlawson mentioned this issue Nov 13, 2023
Merged
@nolanlawson nolanlawson added the Up for grabs Issues that are relatively small, self-contained, and ready for implementation label Nov 13, 2023
nolanlawson added a commit that referenced this issue Dec 11, 2023
@nolanlawson
chore(ci): pin chromedriver version
a42d7a0 
Fixes #3852
@nolanlawson nolanlawson mentioned this issue Dec 11, 2023
Merged
nolanlawson added a commit that referenced this issue Dec 11, 2023
@nolanlawson
chore(ci): pin chromedriver version (#3897)
b58f710 
Fixes #3852
nolanlawson added a commit that referenced this issue Dec 21, 2023
@nolanlawson
chore(ci): pin chromedriver version (#3897)
2b0370d 
Fixes #3852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci tests Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): pin chromedriver version salesforce/lwc
1 participant
@nolanlawson