refactor(engine): Snabbdom V2 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removing unnecessary computations in modules assuming that elements are not longer recyclables * updating snabbdom to v2 * diffing only children * moving snabbdom types into 3rd party to avoid having to wait for the snabbdom releases. * refactoring event module tests to avoid using other snabbdom pieces including patch() * style(engine): Migrate engine to tslint (#995) * Remove traces of eslint * Improve tsconfig and add tslint
caridy
changed the title
Benchmark comparisonBase commit:
|
…th what the compiler produces. delinting.
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
* Test fixes * test fixes * Fixing issue with slots and non-bound keys * Inserting whitespace back in * Fixing compiler tests * Fixing tests in lwc compiler * Updated tests * Refactoring keys to use correct values * Fixing lwc compiler tests: * Keys comments * Fixing all unit tests
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
Benchmark comparisonBase commit:
|
… caridy/diff-refactor
Benchmark comparisonBase commit:
|
1 task
davidturissini
approved these changes
Feb 7, 2018
|
🎉 Youhou 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
**What kind of change does this PR introduce?
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:
The PR fulfills these requirements:
Other information: