Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(engine): Snabbdom V2 #47

Merged
merged 19 commits into from Feb 7, 2018
Merged

refactor(engine): Snabbdom V2 #47

merged 19 commits into from Feb 7, 2018

Commits on Jan 30, 2018

  1. Refactor for Snabbdom V2: 

    * removing unnecessary computations in modules assuming that elements are not longer recyclables
* updating snabbdom to v2
* diffing only children
* moving snabbdom types into 3rd party to avoid having to wait for the snabbdom releases.
* refactoring event module tests to avoid using other snabbdom pieces including patch()
* style(engine): Migrate engine to tslint (#995)
* Remove traces of eslint
* Improve tsconfig and add tslint
    @caridy
    caridy committed Jan 30, 2018
    Configuration menu
    Copy the full SHA
    c0231d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2018

  1. adjusting the tests to reuse the html render function so it aligns wi… 

    …th what the compiler produces. delinting.
    @caridy
    caridy committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    5836b8d View commit details
    Browse the repository at this point in the history

  2. adding api.k() to generalize the creation of unique keys

    @caridy
    caridy committed Feb 1, 2018
    Configuration menu
    Copy the full SHA
    5a12528 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. feat(compiler key): Adding compiler key to template elements (#51) 

    * Test fixes

* test fixes

* Fixing issue with slots and non-bound keys

* Inserting whitespace back in

* Fixing compiler tests

* Fixing tests in lwc compiler

* Updated tests

* Refactoring keys to use correct values

* Fixing lwc compiler tests:

* Keys comments

* Fixing all unit tests
    @davidturissini
    davidturissini committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    188d9d8 View commit details
    Browse the repository at this point in the history

  2. vm.isDirty check

    @davidturissini
    davidturissini committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    db47b0e View commit details
    Browse the repository at this point in the history

  3. adding more tests for template swapping

    @caridy
    caridy committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    41b15ea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'caridy/diff-refactor' of github.com:salesforce/lwc into… 

    … caridy/diff-refactor
    @caridy
    caridy committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    a6856fc View commit details
    Browse the repository at this point in the history

  5. Fixing weakmap issue in api.k

    @davidturissini
    davidturissini committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    811fafc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'caridy/diff-refactor' of github.com:salesforce/lwc into… 

    … caridy/diff-refactor
    @davidturissini
    davidturissini committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    3d81e5f View commit details
    Browse the repository at this point in the history

  7. Unit test fixes

    @davidturissini
    davidturissini committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    817bbfd View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2018

  1. Hoisting unwrap

    @davidturissini
    davidturissini committed Feb 3, 2018
    Configuration menu
    Copy the full SHA
    877a687 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. more types and assertion fixes

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    b3354d5 View commit details
    Browse the repository at this point in the history

  2. more types and linting fixes

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    04d4fd0 View commit details
    Browse the repository at this point in the history

  3. fixing snabbdom to avoid attempting to destroy a non-vnode

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    f273255 View commit details
    Browse the repository at this point in the history

  4. closing the WC semantics on the callbacks

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    3ccb688 View commit details
    Browse the repository at this point in the history

  5. more tests for style

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    aa95849 View commit details
    Browse the repository at this point in the history

  6. Integration test for conditional rendering

    @davidturissini
    davidturissini committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    656aa73 View commit details
    Browse the repository at this point in the history

  7. more types

    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    c838a8f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'caridy/diff-refactor' of github.com:salesforce/lwc into… 

    … caridy/diff-refactor
    @caridy
    caridy committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    cfacb32 View commit details
    Browse the repository at this point in the history