Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split or expose shared utils #39

Closed
jdalton opened this issue Nov 15, 2019 · 1 comment
Closed

split or expose shared utils #39

jdalton opened this issue Nov 15, 2019 · 1 comment

Comments

@jdalton
Copy link
Contributor

jdalton commented Nov 15, 2019

I noticed in the creation of distortion callbacks that we could use the shared utils to avoid prototype methods of arrays, maps, sets, etc. We could expose this as its own scoped package or promote use of @caridy/sjs/lib/shared (seems a bit like reaching for internals that way though).

@caridy
Copy link
Contributor

caridy commented Dec 6, 2019

We discussed this offline... and since that file contains more than just utilities, it contains stuff that are only useful for this project (like the internal whitelist of intrinsics), plus it is very small anyways. We feel that it is ok for folks to have a separate pkg, or just copy them into their project where they plan to write distortions... closing this one.

@caridy caridy closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants