Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maven_install and jvm_import style dependencies #7

Closed
plaird opened this issue Dec 17, 2019 · 3 comments
Closed

Support maven_install and jvm_import style dependencies #7

plaird opened this issue Dec 17, 2019 · 3 comments

Comments

@plaird
Copy link
Contributor

plaird commented Dec 17, 2019

As a Spring Boot rule new user
I would like to have an organized list of Maven dependencies to add to my WORKSPACE
Such that adding Spring Boot is not a painful ordeal.
Such that I can use Bazel 2.0 without issue (no use of maven_jar).
Such that I can use maven_install or jvm_maven_import_external

The problem is seen by looking at https://github.com/salesforce/bazel-springboot-rule/blob/master/external_deps.bzl
It is a mess.

This needs to worked in conjunction with the import bundles work item:
#4

To achieve this, we need to also migrate to this standard:
https://docs.bazel.build/versions/master/skylark/deploying.html

@plaird plaird self-assigned this Mar 24, 2020
@plaird
Copy link
Contributor Author

plaird commented Mar 24, 2020

I have a version that ported this to maven_install, I will post shortly.

@plaird plaird changed the title Clean up external_deps.bzl sample file Migrate off of maven_jar() Mar 24, 2020
@plaird plaird changed the title Migrate off of maven_jar() Support maven_install and jvm_import style dependencies Sep 21, 2020
@plaird
Copy link
Contributor Author

plaird commented Dec 8, 2020

This was done in September.

@plaird
Copy link
Contributor Author

plaird commented Dec 15, 2020

I am reopening - we had a lot of cruft in the import bundles concept left from maven_jar. I am cleaning that up.

@plaird plaird reopened this Dec 15, 2020
Release 1.1: many small improvements automation moved this from To do to In progress Dec 15, 2020
@plaird plaird closed this as completed Jan 5, 2021
Release 1.1: many small improvements automation moved this from In progress to Done Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant