Compilation error for SVN due to missing parenthesis in src/perfmon.c

[GoogleCodeExporter]

The latest SVN does not compile due to a one-character typo in src/perfmon.c.  
Patch attached.  

While I was at I, also cleaned up a bunch of warnings under gcc 4.8.1 related 
to formatting for fprintf().  I haven't verified that they are necessary or 
correct, but they remove the warnings for Linux 3.11.0-26-generic on Haswell.  

The only remaining warnings I get are src/pci.c: 

===>  COMPILE  GCC/pci.o
./src/pci.c: In function ‘pci_init’:
./src/pci.c:161:13: warning: null argument where non-null required (argument 1) 
[-Wnonnull]
             if (!access(bdata(filepath), access_flags))
             ^
./src/pci.c: In function ‘pci_read’:
./src/pci.c:237:13: warning: null argument where non-null required (argument 1) 
[-Wnonnull]
             FD[socketId][device] = open( bdata(filepath), O_RDWR);
             ^
./src/pci.c: In function ‘pci_write’:
./src/pci.c:298:13: warning: null argument where non-null required (argument 1) 
[-Wnonnull]
             FD[socketId][device] = open( bdata(filepath), O_RDWR);
             ^
./src/pci.c: In function ‘pci_tread’:
./src/pci.c:351:13: warning: null argument where non-null required (argument 1) 
[-Wnonnull]
             FD[socketId][device] = open( bdata(filepath), O_RDWR);
             ^
./src/pci.c: In function ‘pci_twrite’:
./src/pci.c:405:13: warning: null argument where non-null required (argument 1) 
[-Wnonnull]
             FD[socketId][device] = open( bdata(filepath), O_RDWR);

Thanks!

--nate

Original issue reported on code.google.com by n...@verse.com on 31 Aug 2014 at 4:28

Attachments:

• likwid_svn_typo_and_warnings.patch

[GoogleCodeExporter]

Hi Nate,

the SVN trunk is under high development and therefore it is possible that it 
does not even compile at all. I'm trying to keep it buildable and runnable but 
not all changes allow that.

Thanks for your patch, I'm not getting these warnings at my test maschine. 
Which compiler and version are you using, some are more strict and louder than 
others

I patched the current trunk version to include your changes. For the Warnings 
in the pci.c file, I will check this when I'm back at the office.

Original comment by Thomas.R...@googlemail.com on 1 Sep 2014 at 10:33

• Changed state: Accepted

[GoogleCodeExporter]

This issue was closed by revision r205.

Original comment by Thomas.R...@googlemail.com on 1 Sep 2014 at 10:42

• Changed state: Fixed