Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong with the stop_child stuff #11

Closed
davidw opened this issue Jun 6, 2013 · 4 comments
Closed

Something is wrong with the stop_child stuff #11

davidw opened this issue Jun 6, 2013 · 4 comments

Comments

@davidw
Copy link
Contributor

davidw commented Jun 6, 2013

I'm not sure entirely what yet, but there is something wrong with the stop_child code.

I've been doing some debugging, and get very strange result for the time difference. I think it has something to do with this:

    uint32_t sec()      const   { return m_tv.tv_sec;  }

By returning it unsigned, it's causing problems, because in reality the difference is a negative number.

@davidw
Copy link
Contributor Author

davidw commented Jun 6, 2013

Another data point:

Something is calling kill(-1, SIGKILL), which has the rather unpleasant side effect of terminating everything - desktop, editors, erlang, window manager, ssh... all of it.

This looks like it might be the culprit:

        kill(ci.kill_cmd_pid, SIGKILL);

@saleyn
Copy link
Owner

saleyn commented Jun 6, 2013

I am currently on vacation. Will try to take a look at it after Jun 20th or so.

@davidw
Copy link
Contributor Author

davidw commented Jun 6, 2013

We need to fix it, so hopefully I'll be able to send a pull request soon.

@davidw
Copy link
Contributor Author

davidw commented Jun 7, 2013

I think I have identified and fixed a few of the problems:

#12

Some tests would be really good to have, though.

@saleyn saleyn closed this as completed Jul 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants