Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOUNTY] Fixing the deprecation warning on macros #30

Closed
11 tasks done
SalieriC opened this issue Nov 1, 2021 · 1 comment
Closed
11 tasks done

[BOUNTY] Fixing the deprecation warning on macros #30

SalieriC opened this issue Nov 1, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SalieriC
Copy link
Owner

SalieriC commented Nov 1, 2021

Many macros have deprecation warnings and need to be updated to work in Foundry v.9

Bounty Notice: I have very limited time atm. Everyone who creates merge requests with (working) updates to the macros which respect changes from Foundry version 9 (and thus gets rid of the warnings in the console) will receive a reward in the form of a free, quality Battle Map¹. You may choose from one of these settings: Medieval Fantasy, Western or Pirates. A merge request covering three or more macros (that have not yet been covered) will be rewarded with an export of the selected map, set up with walls, lights and everything. The first merge request that covers all macros (whether they're already done or not) and works will be rewarded with a custom made battle map created with your specifications (within a reasonable degree of detail).

¹ Battle maps are created using Dungeon Draft. They may not meet the high standards of some patreons out there but they do reach a good quality and assets used are (mainly) those of Forgotten Adventures.

@SalieriC SalieriC added the bug Something isn't working label Nov 1, 2021
@SalieriC
Copy link
Owner Author

Started to make the macros ready for v9. Turns out Mark Dead is fine and (Un-)Stun had an unreported issue because of changes in CUB that have not been reported yet.
Macros that execute Attribute rolls like (Un-)Shake can't be made fully compatible yet as it heavily depends on how those are done in the SWADE system for v9. Thus they possibly will need work after a v9 compatible SWADE version is done. Alternatively the macros could execute the roll directly in the future, getting rid of the modifier dialogue and the chat message with the roll result. I'm on the fence about that though.

@SalieriC SalieriC self-assigned this Dec 16, 2021
@SalieriC SalieriC added this to the v.0.12.0 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant