Implement `semantic-release` for this formula #165

myii · 2019-08-07T16:23:37Z

I've pretty much completed this process but there are a few issues to resolve here, which I'm opening up for discussion in the meantime.

`vagrant` vs. `docker`

openssh-formula/.kitchen.yml

Lines 2 to 14 in 193ff7e

    
           driver: 
        
             name: vagrant 
        
           platforms: 
        
             - name: centos-6.8 
        
             - name: centos-7.2 
        
             - name: ubuntu-14.04 
        
             - name: ubuntu-16.04 
        
             - name: debian-8.5 
        
             - name: freebsd-10.3 
        
               driver: 
        
                 cache_directory: false 
        
             - name: freebsd-11.0

Which of these need to be kept? I'd still have to work on integrating vagrant-based platforms, if those were required.

Serverspec vs. InSpec

The testing section under test/integration.

Any issue with moving over to InSpec?

The text was updated successfully, but these errors were encountered:

aboe76 · 2019-08-07T17:10:50Z

@myii if you want to keep vagrant then you also need to keep Serverspec, I have read somewhere that inspec and vagrant is cumbersome:
https://medium.com/@Joachim8675309/serverspec-vs-inspec-17272df2718f

myii · 2019-08-07T18:52:03Z

@aboe76 What do you suggest? Shall we keep the standard system as used for the rest of the semantic-release formulas and lose vagrant and Serverspec?

daks · 2019-08-08T14:43:57Z

I'm in favor of dropping ServerSpec and going to Inspec.
And there is no reason to not use it with Vagrant, we use it daily (Kitchen on Vagrant + Inspec) and it works :)

myii · 2019-08-08T14:53:03Z

@daks The issue with losing Vagrant is that we lose the FreeBSD testing, that I linked to in the first comment. Now, if we could get FreeBSD working on Cirrus CI, then it wouldn't matter so much.

daks · 2019-08-08T15:22:01Z

@myii OK, what I said is that I'm not sure @aboe76 is right saying that Vagrant and Inspec are a problem. Vagrant (using Kitchen) and Inspec works fine together.

myii · 2019-08-08T15:50:41Z

@daks Have you had experience with running both Vagrant and Docker from the same kitchen.yml? I'm sure it works fine and that way we can keep the FreeBSD at least. I just wanted to tap in to others' experience before investing any time into this.

aboe76 · 2019-08-08T19:57:17Z

@daks I'm ok with dropping serverspec in favor for inspec, didn't take in account we use kitchen too..

daks · 2019-08-09T08:46:17Z

@daks Have you had experience with running both Vagrant and Docker from the same kitchen.yml? I'm sure it works fine and that way we can keep the FreeBSD at least. I just wanted to tap in to others' experience before investing any time into this.

No experience in using both.

baby-gnu · 2019-09-03T11:52:34Z

Hello.

I just started looking to modify test infrastructure for this formula and I'm happy to see this issue first ;-)

vagrant vs. docker

Maybe we can use a standard kitchen way to parameterize the kitchen.yml as you can see in salt kitchen.yml file itself?

myii · 2019-09-06T08:06:09Z

As a note, Travis doesn't support using Vagrant:

A useful idea could be to take advantage of Cirrus CI, which paves the way for *BSD and Windows testing. More investigation would be required.

myii · 2019-09-09T22:24:33Z

This issue could be resolved by adopting a similar method to:

feat(freebsd): add FreeBSD support vault-formula#32

n-rodriguez · 2019-09-09T23:05:36Z

I have a case for a full vagrant/virtual box/kvm/whatever formula : https://travis-ci.com/n-rodriguez/nfs-formula/jobs/232512930

* Close saltstack-formulas#165 * Move existing `.kitchen.yml` => `kitchen.vagrant.yml`

myii · 2019-09-11T16:50:55Z

I've shared the current progress in #166, listing the tasks that still need to be done.

* Close saltstack-formulas#165 * Move existing `.kitchen.yml` => `kitchen.vagrant.yml` ```bash openssh-formula$ yamllint -s . ./pillar.example 49:3 error duplication of key "AllowUsers" in mapping (key-duplicates) 57:3 error duplication of key "DenyUsers" in mapping (key-duplicates) 63:3 error duplication of key "AllowGroups" in mapping (key-duplicates) 70:3 error duplication of key "DenyGroups" in mapping (key-duplicates) 79:24 warning truthy value should be one of [false, true] (truthy) 80:29 warning truthy value should be one of [false, true] (truthy) 118:4 warning missing starting space in comment (comments) 119:4 warning missing starting space in comment (comments) 119:89 error line too long (122 > 88 characters) (line-length) 120:4 warning missing starting space in comment (comments) 120:89 error line too long (144 > 88 characters) (line-length) 147:30 warning truthy value should be one of [false, true] (truthy) 148:21 warning truthy value should be one of [false, true] (truthy) 149:19 warning truthy value should be one of [false, true] (truthy) 150:32 warning truthy value should be one of [false, true] (truthy) 151:26 warning truthy value should be one of [false, true] (truthy) 152:31 warning truthy value should be one of [false, true] (truthy) 153:32 warning truthy value should be one of [false, true] (truthy) 154:29 warning truthy value should be one of [false, true] (truthy) 155:34 warning truthy value should be one of [false, true] (truthy) 175:8 warning missing starting space in comment (comments) 175:89 error line too long (152 > 88 characters) (line-length) 176:8 warning missing starting space in comment (comments) 176:89 error line too long (126 > 88 characters) (line-length) 177:8 warning missing starting space in comment (comments) 177:89 error line too long (148 > 88 characters) (line-length) 213:18 warning truthy value should be one of [false, true] (truthy) 219:18 warning truthy value should be one of [false, true] (truthy) 225:18 warning truthy value should be one of [false, true] (truthy) 241:22 warning truthy value should be one of [false, true] (truthy) 243:22 warning truthy value should be one of [false, true] (truthy) 244:20 warning truthy value should be one of [false, true] (truthy) 245:21 warning truthy value should be one of [false, true] (truthy) 254:24 warning truthy value should be one of [false, true] (truthy) 255:22 warning truthy value should be one of [false, true] (truthy) 256:23 warning truthy value should be one of [false, true] (truthy) 265:22 warning truthy value should be one of [false, true] (truthy) 268:21 warning truthy value should be one of [false, true] (truthy) 269:20 warning truthy value should be one of [false, true] (truthy) 270:21 warning truthy value should be one of [false, true] (truthy) 279:26 warning truthy value should be one of [false, true] (truthy) 280:24 warning truthy value should be one of [false, true] (truthy) 281:25 warning truthy value should be one of [false, true] (truthy) 307:16 warning truthy value should be one of [false, true] (truthy) 308:6 warning missing starting space in comment (comments) 314:6 warning missing starting space in comment (comments) 316:24 warning truthy value should be one of [false, true] (truthy) 339:89 error line too long (546 > 88 characters) (line-length) 340:89 error line too long (546 > 88 characters) (line-length) 341:89 error line too long (546 > 88 characters) (line-length) 342:89 error line too long (546 > 88 characters) (line-length) 344:4 warning missing starting space in comment (comments) 345:4 warning missing starting space in comment (comments) 357:19 warning truthy value should be one of [false, true] (truthy) ./openssh/osfamilymap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/osfingermap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/osmap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/defaults.yaml 1:1 warning missing document start "---" (document-start) 3:18 warning truthy value should be one of [false, true] (truthy) 6:34 warning too few spaces before comment (comments) 10:25 warning truthy value should be one of [false, true] (truthy) 12:32 warning too few spaces before comment (comments) 16:24 warning truthy value should be one of [false, true] (truthy) 18:24 warning too few spaces before comment (comments) 20:42 warning too few spaces before comment (comments) 27:6 warning missing starting space in comment (comments) ```

myii · 2019-09-12T02:56:52Z

Another idea, #166 has many parts that are ready to go. How about we merge it and then fix the remaining things as we go along? Otherwise, it may end up stagnating over time. Even in it's current state, it works fine. There was no automated testing here anyway.

daks · 2019-09-12T09:05:59Z

@myii looks fine to me

* Close saltstack-formulas#165 * Move existing `.kitchen.yml` => `kitchen.vagrant.yml` * Semi-automated using myii/ssf-formula#30 * Fix errors shown below: ```bash openssh-formula$ yamllint -s . ./pillar.example 49:3 error duplication of key "AllowUsers" in mapping (key-duplicates) 57:3 error duplication of key "DenyUsers" in mapping (key-duplicates) 63:3 error duplication of key "AllowGroups" in mapping (key-duplicates) 70:3 error duplication of key "DenyGroups" in mapping (key-duplicates) 79:24 warning truthy value should be one of [false, true] (truthy) 80:29 warning truthy value should be one of [false, true] (truthy) 118:4 warning missing starting space in comment (comments) 119:4 warning missing starting space in comment (comments) 119:89 error line too long (122 > 88 characters) (line-length) 120:4 warning missing starting space in comment (comments) 120:89 error line too long (144 > 88 characters) (line-length) 147:30 warning truthy value should be one of [false, true] (truthy) 148:21 warning truthy value should be one of [false, true] (truthy) 149:19 warning truthy value should be one of [false, true] (truthy) 150:32 warning truthy value should be one of [false, true] (truthy) 151:26 warning truthy value should be one of [false, true] (truthy) 152:31 warning truthy value should be one of [false, true] (truthy) 153:32 warning truthy value should be one of [false, true] (truthy) 154:29 warning truthy value should be one of [false, true] (truthy) 155:34 warning truthy value should be one of [false, true] (truthy) 175:8 warning missing starting space in comment (comments) 175:89 error line too long (152 > 88 characters) (line-length) 176:8 warning missing starting space in comment (comments) 176:89 error line too long (126 > 88 characters) (line-length) 177:8 warning missing starting space in comment (comments) 177:89 error line too long (148 > 88 characters) (line-length) 213:18 warning truthy value should be one of [false, true] (truthy) 219:18 warning truthy value should be one of [false, true] (truthy) 225:18 warning truthy value should be one of [false, true] (truthy) 241:22 warning truthy value should be one of [false, true] (truthy) 243:22 warning truthy value should be one of [false, true] (truthy) 244:20 warning truthy value should be one of [false, true] (truthy) 245:21 warning truthy value should be one of [false, true] (truthy) 254:24 warning truthy value should be one of [false, true] (truthy) 255:22 warning truthy value should be one of [false, true] (truthy) 256:23 warning truthy value should be one of [false, true] (truthy) 265:22 warning truthy value should be one of [false, true] (truthy) 268:21 warning truthy value should be one of [false, true] (truthy) 269:20 warning truthy value should be one of [false, true] (truthy) 270:21 warning truthy value should be one of [false, true] (truthy) 279:26 warning truthy value should be one of [false, true] (truthy) 280:24 warning truthy value should be one of [false, true] (truthy) 281:25 warning truthy value should be one of [false, true] (truthy) 307:16 warning truthy value should be one of [false, true] (truthy) 308:6 warning missing starting space in comment (comments) 314:6 warning missing starting space in comment (comments) 316:24 warning truthy value should be one of [false, true] (truthy) 339:89 error line too long (546 > 88 characters) (line-length) 340:89 error line too long (546 > 88 characters) (line-length) 341:89 error line too long (546 > 88 characters) (line-length) 342:89 error line too long (546 > 88 characters) (line-length) 344:4 warning missing starting space in comment (comments) 345:4 warning missing starting space in comment (comments) 357:19 warning truthy value should be one of [false, true] (truthy) ./openssh/osfamilymap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/osfingermap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/osmap.yaml 1:1 warning missing document start "---" (document-start) ./openssh/defaults.yaml 1:1 warning missing document start "---" (document-start) 3:18 warning truthy value should be one of [false, true] (truthy) 6:34 warning too few spaces before comment (comments) 10:25 warning truthy value should be one of [false, true] (truthy) 12:32 warning too few spaces before comment (comments) 16:24 warning truthy value should be one of [false, true] (truthy) 18:24 warning too few spaces before comment (comments) 20:42 warning too few spaces before comment (comments) 27:6 warning missing starting space in comment (comments) ```

myii · 2019-09-13T03:33:16Z

Thanks @daks, I've gone ahead with merging #166 and creating issue #167.

# [0.42.0](v0.41.0...v0.42.0) (2019-09-13) ### Features * **semantic-release:** implement for this formula ([6300ddf](6300ddf)), closes [#165](#165)

saltstack-formulas-travis · 2019-09-13T03:43:36Z

🎉 This issue has been resolved in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

myii mentioned this issue Sep 10, 2019

Build images for Vagrant netmanagers/salt-image-builder#6

Closed

myii added a commit to myii/openssh-formula that referenced this issue Sep 11, 2019

feat(semantic-release): implement for this formula

a7cccb1

* Close saltstack-formulas#165 * Move existing `.kitchen.yml` => `kitchen.vagrant.yml`

myii mentioned this issue Sep 11, 2019

feat(semantic-release): implement for this formula #166

Merged

4 tasks

myii closed this as completed in #166 Sep 13, 2019

saltstack-formulas-travis pushed a commit that referenced this issue Sep 13, 2019

chore(release): 0.42.0 [skip ci]

09b44cb

# [0.42.0](v0.41.0...v0.42.0) (2019-09-13) ### Features * **semantic-release:** implement for this formula ([6300ddf](6300ddf)), closes [#165](#165)

saltstack-formulas-travis added the released label Sep 13, 2019

myii mentioned this issue Jul 17, 2020

fix(test): make rubocop happy #181

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `semantic-release` for this formula #165

Implement `semantic-release` for this formula #165

myii commented Aug 7, 2019 •

edited

aboe76 commented Aug 7, 2019

myii commented Aug 7, 2019 •

edited

daks commented Aug 8, 2019 •

edited

myii commented Aug 8, 2019

daks commented Aug 8, 2019

myii commented Aug 8, 2019 •

edited

aboe76 commented Aug 8, 2019

daks commented Aug 9, 2019

baby-gnu commented Sep 3, 2019

myii commented Sep 6, 2019

myii commented Sep 9, 2019

n-rodriguez commented Sep 9, 2019

myii commented Sep 11, 2019

myii commented Sep 12, 2019

daks commented Sep 12, 2019

myii commented Sep 13, 2019

saltstack-formulas-travis commented Sep 13, 2019

Implement semantic-release for this formula #165

Implement semantic-release for this formula #165

Comments

myii commented Aug 7, 2019 • edited

vagrant vs. docker

Serverspec vs. InSpec

aboe76 commented Aug 7, 2019

myii commented Aug 7, 2019 • edited

daks commented Aug 8, 2019 • edited

myii commented Aug 8, 2019

daks commented Aug 8, 2019

myii commented Aug 8, 2019 • edited

aboe76 commented Aug 8, 2019

daks commented Aug 9, 2019

baby-gnu commented Sep 3, 2019

myii commented Sep 6, 2019

myii commented Sep 9, 2019

n-rodriguez commented Sep 9, 2019

myii commented Sep 11, 2019

myii commented Sep 12, 2019

daks commented Sep 12, 2019

myii commented Sep 13, 2019

saltstack-formulas-travis commented Sep 13, 2019

Implement `semantic-release` for this formula #165

Implement `semantic-release` for this formula #165

myii commented Aug 7, 2019 •

edited

`vagrant` vs. `docker`

myii commented Aug 7, 2019 •

edited

daks commented Aug 8, 2019 •

edited

myii commented Aug 8, 2019 •

edited