-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): make rubocop happy #181
fix(test): make rubocop happy #181
Conversation
All tests provided by Serverspec are covered by Inspec.
* test/integration/default/controls/services_spec.rb: favor modifier if usage when having a single-line body. * test/integration/default/controls/config_spec.rb: add frozen string literal comment. * test/integration/default/controls/packages_spec.rb: ditoo. * test/integration/default/controls/services_spec.rb: ditoo.
Best reviewed: with all changes
Optimal code review plan (2 commits squashed)
|
@baby-gnu Thanks for the PR. Couple of bits of feedback for you:
|
# Run the `rubocop` linter in a separate job that is allowed to fail | |
# Once these lint errors are fixed, this can be merged into a single job |
So that's simply using the structure from the template-formula
here.
|
@baby-gnu OK, let's get this merged! |
Closed #167, since no longer seems valid. |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
#167
Describe the changes you're proposing
This PR:
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context