issues running formula

[ppwd]

I was getting the following error running this updated formula.

Requisite declaration download-jdk-archive in SLS sun-java is not formed as a single key dictionary

changing the following block from

check-jdk-archive:
  module.run:
    - name: file.check_hash
    - path: {{ archive_file }}
    - file_hash: {{ java.source_hash }}
    - onchanges:
      - download-jdk-archive
    - require_in:
      - archive: unpack-jdk-archive

to

check-jdk-archive:
  module.run:
    - name: file.check_hash
    - path: {{ archive_file }}
    - file_hash: {{ java.source_hash }}
    - onchanges:
      - cmd: download-jdk-archive
    - require_in:
      - archive: unpack-jdk-archive

basically added the correct type of requisite (- cmd: download-jdk-archive)

[noelmcloughlin]

I used same form in updated sun-java.env state, but now there seems to be some caveat? Does older Salt version require type to be explicit? Thank you.

`+ - require:

• • javahome-alt-install`

[ppwd]

it's possible that it's not required in newer versions. Probably should have posted this before but i am running version (2015.8.8 (Beryllium))

I assumed it was a typo because the state directly following in the SLS (unpack-jdk-archive) also listens for changes, however it directly specifies the cmd portion.

[noelmcloughlin]

@vutny Should I fix this general issue in my PR for backwards compatibility? Sounds like a bug.

[noelmcloughlin]

@ppwd Could you test again please now, thanks

[ppwd]

@noelmcloughlin

just tested this again with the latest changes and it appears to be fine now.

Thanks!

[noelmcloughlin]

That's great news. Thanks for testing!!!