added python-psutil to fedora deps #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robnagler - I don't think we want to add this dependency to the bootstrap script. Installing this package should remain optional in bootstrap. We are working on a change in Salt to not stack trace when psutil cannot be imported right now (see saltstack/salt#34043). |
|
@robnagler Thank you again for submitting this. The error caused by saltstack/salt#33942 has now been resolved by saltstack/salt#34182 and is available at the HEAD of all current release branches, which makes this change unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added Fedora dependency python-psutil.
What issues does this PR fix or reference?
Prints stack trace if psutil not available: saltstack/salt#33942
Tests written?
No