Handle child PIDs differently depending on the availability of psutils #34182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the change made in #33942, we are assuming that psutils is installed. This change checks if psutil is installed, and if it's not, it reverts back to the old behavior. If it is not installed, a warning is logged mentioning the missing dependency.
What issues does this PR fix or reference?
Fixes #34043
Previous Behavior
Stack traces would happen on calls that used and
saltutilmodule function, as psutil couldn't be imported.New Behavior
No more stacktraces when psutils is missing, warns when psutil isn't installed, and reverts back to old PID management.
Tests written?
No
ping @cachedout