Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dig.SPF does not recurse includes/redirects #10367

Closed
rallytime opened this issue Feb 11, 2014 · 2 comments · Fixed by #10403
Closed

dig.SPF does not recurse includes/redirects #10367

rallytime opened this issue Feb 11, 2014 · 2 comments · Fixed by #10403
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists

Comments

@rallytime
Copy link
Contributor

The SPF function has a bug in it concerning when a domain is redirecting the SPF ipv4 range. See #10366 for more info. A test illustrating this problem is here: https://github.com/saltstack/salt/blob/develop/tests/unit/modules/dig_test.py#L81

Here is a test case for a SPF that does not redir and works as expected:
https://github.com/saltstack/salt/blob/develop/tests/unit/modules/dig_test.py#L67

@terminalmage terminalmage added this to the Outstanding Bugs milestone Feb 11, 2014
@terminalmage
Copy link
Contributor

Thanks for doing the legwork with the test, and thanks for reporting this, we'll take care of it.

@rallytime
Copy link
Contributor Author

Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants