Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file.check_perms breaks with symlinks #11387

Closed
johtso opened this issue Mar 20, 2014 · 3 comments
Closed

file.check_perms breaks with symlinks #11387

johtso opened this issue Mar 20, 2014 · 3 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix help-wanted Community help is needed to resolve this severity-low 4th level, cosemtic problems, work around exists

Comments

@johtso
Copy link
Contributor

johtso commented Mar 20, 2014

There is inconsistent use of follow_symlinks in file.check_perms

The owner of the file is first checked using state with follow_symlinks=False, and then with get_user which defaults to follow_symlinks=True.

This causes the state to fail for symlinks that have the correct ownership but point to files that have different ownership.

Looks to be caused by this change: 7d4c470#diff-7c48191b14cdf053cf954d03cc317963L2195

@johtso johtso changed the title Inconsistent use of follow_symlinks in file.check_perms file.check_perms breaks with symlinks Mar 20, 2014
@basepi
Copy link
Contributor

basepi commented Mar 24, 2014

Good catch, thank you!

@terminalmage looks like you made this change, so I just wanted to double check that we weren't missing anything. I expect both should be follow_symlinks=False, but wanted to double check.

@rallytime
Copy link
Contributor

@johtso - can you take a look and see if this PR fixes your issue?

@rallytime
Copy link
Contributor

Since we haven't heard of any other reports regarding this issue, I am going to close it. We are certainly happy to re-open it if people are still seeing problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix help-wanted Community help is needed to resolve this severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

3 participants