Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the best practices documentation to include simpler examples of of jinja dictionaries #23522

Closed
nbirnel opened this issue May 10, 2015 · 3 comments
Labels
Documentation Relates to Salt documentation Feature new functionality including changes to functionality and code refactors, etc. fixed-pls-verify fix is linked, bug author to confirm fix
Milestone

Comments

@nbirnel
Copy link
Contributor

nbirnel commented May 10, 2015

Currently the best practices (http://docs.saltstack.com/en/latest/topics/best_practices.html) includes an example of a separate map.jinja file, with a merge
of pillar data. This is probably overkill for simpler use case scenarios. The best practices should
include a simple dictionary, eg:

{% set auditd = salt['grains.filter_by']({
  'RedHat': { 'package': 'audit' },
  'Debian': { 'package': 'auditd' },
}) %}

gravyboat asked me to add this issue after the first Seattle Saltstack user's meetup.

@jfindlay jfindlay added Feature new functionality including changes to functionality and code refactors, etc. Documentation Relates to Salt documentation labels May 11, 2015
@jfindlay jfindlay added this to the Approved milestone May 11, 2015
@jfindlay
Copy link
Contributor

@nbirnel, thanks for the report.

jacobhammons added a commit to jacobhammons/salt that referenced this issue Jun 14, 2016
Removes the "Full list of builtin ..." from each module reference list, leaving just the module type for scanability.

Refs saltstack#12470
Refs saltstack#10206
Refs saltstack#10480
Refs saltstack#23522
Refs saltstack#33023
@jacobhammons
Copy link
Contributor

I added this example to the Understanding Jinja topic at https://docs.saltstack.com/en/latest/topics/jinja/index.html, it is at the bottom of the first section.

@nbirnel If you agree that this fixes the issue please close. Thanks!

@jacobhammons jacobhammons added the fixed-pls-verify fix is linked, bug author to confirm fix label Jun 14, 2016
@nbirnel
Copy link
Contributor Author

nbirnel commented Jun 14, 2016

@jacobhammons Thanks, that looks good to me.

@nbirnel nbirnel closed this as completed Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to Salt documentation Feature new functionality including changes to functionality and code refactors, etc. fixed-pls-verify fix is linked, bug author to confirm fix
Projects
None yet
Development

No branches or pull requests

3 participants