Jinja import: Jinja variable 'salt' is undefined

[rabits]

Description:

I can't import an jinja template that uses predefined variables (like salt, pillar, grains etc) into another template.

Example:

• openssl/init.sls:

#
# OpenSSL crypto library
#

{% import 'openssl/vars.sls' as ssl %}

• openssl/vars.ssl

{% set var_home   = salt['pillar.get']('ssl:home', '/srv/ssl') %}

• Output:

    Data failed to compile:
----------
    Rendering SLS "master:openssl" failed: Jinja variable 'salt' is undefined; line 1

---
#    <======================
# OpenSSL crypto library
#

{% import 'openssl/vars.sls' as ssl %}

[...]

---

• Version:

ubuntu 12.04 $ salt --versions-report
           Salt: 0.17.5
         Python: 2.7.3 (default, Sep 26 2013, 16:35:25)
         Jinja2: 2.6
       M2Crypto: 0.21.1
 msgpack-python: 0.1.10
   msgpack-pure: Not Installed
       pycrypto: 2.6
         PyYAML: 3.10
          PyZMQ: 13.0.0
            ZMQ: 3.2.2

Thanks

[basepi]

I'm guessing this has something to do with the way that we're injecting those salt-specific variables into the template context. I'm unsure of what it will take (or if it's possible) to inject them into includes as well, but we'll definitely look into it!

[kiorky]

i thinked i may have fixed that via #10307

[rabits]

Thank you! For now I can't check this, but I will try later.

[rabits]

Seems like this patch #10307 is not working for my bug (tested on 2014.1.0 release)

[mway]

FWIW, this is still an issue on 2014.1.3 (via PPA). One (cheap) workaround is to wrap the included template in a macro and pass salt (etc) when calling it, but if you're not already using macros, that's certainly not ideal.

[basepi]

@mway This did not get cherry-picked, so the patch is not in 2014.1.3. Could you potentially try applying the patch in #10307 and see if it fixes your issue?

[mway]

Ah, thanks, should've realized. Went to test and realized that this was a silly oversight on my part (I forgot to re-add a with context to the import statement), so I'm no longer seeing the issue in general. Sorry for the noise!

[rabits]

Wow, seems like it's works with

{% import 'openssl/vars.sls' as ssl with context %}

in version 2013.1.1 without patches ))

[basepi]

Oh good call! I forgot about with context. I think that solves it nicely! We just need to add this prominently to the docs.

[jacobhammons]

I've added the note about 'with context' at https://docs.saltstack.com/en/latest/topics/jinja/index.html#including-context-during-include-import

@rabits if you think this fix is sufficient please close. Thanks.

[rabits]

Thank you) Totally forgot about closing