Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt-cloud broken starting with Python Azure lib 2015-08-31 Version 1.0.0 #27330

Closed
bradthurber opened this issue Sep 23, 2015 · 5 comments
Closed
Assignees
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@bradthurber
Copy link
Contributor

Lots of breaking changes in Python Azure lib 2015-08-31 Version 1.0.0 cause salt-cloud azure to be completely broken.

See the BREAKING CHANGES section of the change log for the many changes (moves/renames).

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Salt-Cloud P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Sep 23, 2015
@rallytime rallytime added this to the Approved milestone Sep 23, 2015
@rallytime
Copy link
Contributor

@bradthurber Thanks very much for logging this issue. I thought we had an issue already open tracking this, but it appears that I can't find it at the moment. We'll certainly need to get the salt-cloud driver up to speed.

@techhat You're probably already aware of this, but if not, FYI.

@rallytime
Copy link
Contributor

Oh! I found it. It was #26863, but since that has been closed, we can track the progress of this change here. Thanks again, and if you're feeling inclined, we're always happy to accept pull requests!

@rallytime
Copy link
Contributor

Comment from @bogdanr in duplicate issue #28009:

Since the 1.0.0 azure python package some of the functions were renamed and the provider from salt can't work anymore.

The following were renamed and moved from 'azure' to 'azure.common':
WindowsAzureError -> AzureException and AzureHttpError
WindowsAzureConflictError -> AzureConflictHttpError
WindowsAzureMissingResourceError -> AzureMissingResourceHttpError

The following were renamed and moved from 'azure' to 'azure.servicemanagement':
WindowsAzureAsyncOperationError -> AzureAsyncOperationHttpError

The following were renamed and moved from 'azure' to 'azure.storage':
WindowsAzureBatchOperationError -> AzureBatchOperationError

@techhat Just an FYI about these issues as well for when you're working on this.

@rallytime
Copy link
Contributor

@bradthurber and @bogdanr - PR #28571 was just submitted to the develop branch to address this issue. Are either of you in a position to give that a try?

@meggiebot meggiebot modified the milestones: B 8, B 9 Nov 18, 2015
@techhat
Copy link
Contributor

techhat commented Nov 24, 2015

Fixed by #28481.

@techhat techhat closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

5 participants