New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt-key -a/-r keys not in unaccepted #7399

Closed
VertigoRay opened this Issue Sep 21, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@VertigoRay
Contributor

VertigoRay commented Sep 21, 2013

If a key is accepted, and then I want to reject it: I run salt-key -r and get the following message:

No keys found to reject

If a key is rejected, and then I want to accept it: I run salt-key -a and get the following message:

The key glob MY_KEY_NAME does not match any unaccepted keys.

Moving the key to the respective pki_dir causes the key to work based on the pki_dir that it's in. So the issue is just that the salt-key command isn't looking in all the pki_dir.

# salt-master --versions-report
           Salt: 0.16.4
         Python: 2.6.6 (r266:84292, Dec 26 2010, 22:31:48)
         Jinja2: 2.5.5
       M2Crypto: 0.20.1
 msgpack-python: 0.1.10
   msgpack-pure: Not Installed
       pycrypto: 2.1.0
         PyYAML: 3.09
          PyZMQ: 13.1.0
            ZMQ: 3.2.3
@basepi

This comment has been minimized.

Member

basepi commented Sep 23, 2013

Ah yes, both of those commands only look in the unaccepted directory. You're probably right, we should support all those directories with these commands.

Not exactly sure if it will be as easy as pointing it to those other directories as well, but we'll definitely look into it.

@terminalmage

This comment has been minimized.

Member

terminalmage commented Sep 29, 2013

I just submitted a pull request that implements this, but before it's merged I'd like it to be discussed. See #7509.

@VertigoRay

This comment has been minimized.

Contributor

VertigoRay commented Sep 30, 2013

Thanks for your work on this, @terminalmage

@terminalmage

This comment has been minimized.

Member

terminalmage commented Oct 2, 2013

@VertigoRay no prob, thanks for the suggestion!

Since this was merged, I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment