Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg.mod_repo is Wrong #7656

Closed
zhausong opened this issue Oct 7, 2013 · 4 comments · Fixed by #7800
Closed

pkg.mod_repo is Wrong #7656

zhausong opened this issue Oct 7, 2013 · 4 comments · Fixed by #7800
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists

Comments

@zhausong
Copy link
Contributor

zhausong commented Oct 7, 2013

salt-master,salt-minion version is 0.16.4 from epel repo with rpm install.
On master run cmd like this

salt node1 pkg.mod_repo epel-source enabled=1 gpgcheck=1

node1:
    ----------
    /etc/yum.repos.d/epel_sohu.repo:
        ----------
        epel-source:
            ----------
            __pub_arg:
                - epel-source
                - enabled=1
                - gpgcheck=1
            __pub_fun:
                pkg.mod_repo
            __pub_jid:
                20131008082431705781
            __pub_tgt:
                node1
            __pub_tgt_type:
                glob
            __pub_user:
                root
            baseurl:
                http://mirrors.sohu.com/fedora-epel/6Server/x86_64/
            enabled:
                1
            gpgcheck:
                1
            gpgkey:
                file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6
            name:
                Extra Packages for Enterprise Linux 6 - $basearch - Source

On minion

before run "salt node1 pkg.mod_repo epel-source enabled=1 gpgcheck=1" like this

cat epel_sohu.repo

[epel-source]
name=Extra Packages for Enterprise Linux 6 - $basearch - Source
baseurl=http://mirrors.sohu.com/fedora-epel/6Server/x86_64/
enabled=1
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6
gpgcheck=1

when run "salt node1 pkg.mod_repo epel-source enabled=1 gpgcheck=1" like this

cat epel_sohu.repo

[epel-source]
__pub_user=root
__pub_arg=['epel-source', 'enabled=1', 'gpgcheck=1']
name=Extra Packages for Enterprise Linux 6 - $basearch - Source
gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-6
enabled=1
baseurl=http://mirrors.sohu.com/fedora-epel/6Server/x86_64/
__pub_fun=pkg.mod_repo
__pub_jid=20131008082431705781
__pub_tgt=node1
gpgcheck=1
__pub_tgt_type=glob

the result is wrong.

@basepi
Copy link
Contributor

basepi commented Oct 9, 2013

Updated original post with triple backticks and whitespace for readability.

This does look like it's wrong. Was it right on a previous version or did you just start using mod_repo?

In any case, thanks for the report.

@zhausong
Copy link
Contributor Author

zhausong commented Oct 9, 2013

@basepi thank you!
I clone the github of current version,the problem is already exist!

@basepi
Copy link
Contributor

basepi commented Oct 9, 2013

Wait, I'm having a hard time following. Does the problem exist in the current develop branch? And is it a new bug or did it always exist?

@zhausong
Copy link
Contributor Author

Thank you @basepi, this bug is always exist,from 0.16, 0.17 and the current develop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants