Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgrepo, pkg.latest upgrade is incomplete with test=True #8247

Closed
pille opened this issue Nov 4, 2013 · 2 comments
Closed

pkgrepo, pkg.latest upgrade is incomplete with test=True #8247

pille opened this issue Nov 4, 2013 · 2 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this

Comments

@pille
Copy link
Contributor

pille commented Nov 4, 2013

i've noticed an incompleteness of output using test=True, when migrating from a distribution package repo to a backport-repo providing newer versions.

let's assume htop is installed from ubuntu-precise.
running a highstate using test=True will just show that pkgrepo.managed is executed. it won't detect that the package needs to be upgraded, as applying highstate normally does:

state.highstate:

----------
    State: - pkgrepo
    Name:      precise-bleed
    Function:  managed
        Result:    True
        Comment:   Configured package repo precise-bleed
        Changes:   repo: ppa:precisebleed/ppa
                   
----------
    State: - pkg
    Name:      htop
    Function:  latest
        Result:    True
        Comment:   The following packages were successfully installed/upgraded: htop.
        Changes:   htop: { new : 1.0.2-2~ppa1~precise1
old : 1.0.1-1
}
                   
----------

i can understand why this probably happens.
since the pkgrepo is not added for read during simulation, there's no package-information-change available and salt cannot see the available upgrade.
since the simulation diverges from reality, please at least include a hint in such situations, that additional packages may be changed.

i guess that's all you can do without running a real simulation.

@basepi
Copy link
Contributor

basepi commented Nov 4, 2013

Yes, you hit the nail on the head. Since we aren't actually making the pkgrepo change or running an update, we have no idea whether new packages will be available.

We should add a note if test=True to say that some packages might require updates even if the states say they don't. Is that acceptable?

@terminalmage
Copy link
Contributor

Closing as the test=True message have been updated as discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this
Projects
None yet
Development

No branches or pull requests

3 participants