pkgrepo.managed doesn't handle moving from mirrorlist to baseurl on Yum based systems

[tlk2126]

If you switch from a mirrorlist configured pkgrepo:

repo-epel:
    pkgrepo:
        - managed
        - name: epel
        ...
        - mirrorlist: https://mirrors.fedoraproject.org/metalink?repo=epel-source-6&arch=$basearch

to

repo-epel:
    pkgrepo:
        - managed
        - name: epel
        ...
        - baseurl: http://mirror.cc.columbia.edu/pub/linux/epel/6/$basearch/

and run a state.highstate, the proper baseurl line is added, but the mirrorlist line is left in the configuration, which means yum will still try to use that.

[basepi]

Thanks for catching this! We'll get it fixed.

[basepi]

What version of salt are you running?

[terminalmage]

I'm fairly certain this will affect all versions, since all the args in the state are passed through to the function that writes the repo config file. I'll add some logic to include a check on yum-based systems for this sort of change.

[terminalmage]

@tlk2126 I've submitted a fix for this in #9133. Due to the way changes are returned from pkgrepo states currently, Salt doesn't report that it has deleted the corresponding key when it shows the changes in the highstate output. Doing this will require more substantial changes to the apt and yum pkgrepo functions as well as the pkgrepo state, so this will have to be done another time. But for now, the behavior will be functionally accurate, which is more important IMO than for the reporting of changes to be 100% accurate. We'll still get to that, it just might take a few weeks. :)

Thanks again for reporting this!