support amazon linux 2 for service module #45764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Jan 30, 2018
salt/modules/rh_service.py
Outdated
| else: | ||
| return ( | ||
| False, | ||
| 'Amazon Linux >= version 2 use systemd, will not ' |
There was a problem hiding this comment.
use --> uses and then maybe let's split the message up into 2 sentences with systemd. Will not.
|
Edited the copy/pasted bits! |
rallytime
approved these changes
Jan 30, 2018
terminalmage
approved these changes
Feb 2, 2018
|
@rallytime I think this should be added to the RC branch. |
terminalmage
added
ZRELEASED - 2018.3.0
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
rallytime
pushed a commit
that referenced
this pull request
Feb 2, 2018
Back-port #45764 to oxygen.rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Same as #45758, but for the 2017.7 branch. Disables rh_service.py on Amazon Linux 2
Previous Behavior
service.running states ran via rh_service.py rather than systemd and failed.
New Behavior
Systemd is used to manage service calls and runs properly.
Tests written?
No
Commits signed with GPG?
No