Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap package management #51625

Merged
merged 24 commits into from
Feb 13, 2019
Merged

Add snap package management #51625

merged 24 commits into from
Feb 13, 2019

Conversation

lordcirth
Copy link
Contributor

What does this PR do?

Adds the state module 'snap' containing 'snap.installed' and 'snap.removed'.

What issues does this PR fix or reference?

#27007

Tests written?

No

Commits signed with GPG?

No

@dwoz
Copy link
Contributor

dwoz commented Feb 13, 2019

@lordcirth The docs failed to build, please have a look a this. :) Thanks!

@lordcirth
Copy link
Contributor Author

@lordcirth The docs failed to build, please have a look a this. :) Thanks!

Yes, I forgot to lint the docs as well. It's going to take a while to run the linter on my machine, but I'm working on it.

@lordcirth
Copy link
Contributor Author

@dwoz please review again. Thanks.

@dwoz dwoz merged commit a814029 into saltstack:develop Feb 13, 2019
@lordcirth lordcirth deleted the add-snap-pkg branch February 14, 2019 15:15
@steveno steveno mentioned this pull request Mar 6, 2019
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 24, 2019
alexey-zhukovin pushed a commit to alexey-zhukovin/salt that referenced this pull request Apr 28, 2020
@alexey-zhukovin alexey-zhukovin moved this from PR needs port to master to PR has port to master in PRs to port to master Apr 28, 2020
@alexey-zhukovin alexey-zhukovin added the has master-port port to master has been created label Apr 28, 2020
@alan-cugler
Copy link
Contributor

Is this still expected to be committed at some point? or a dead PR merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has master-port port to master has been created
Projects
PRs to port to master
  
PR has port to master
Development

Successfully merging this pull request may close these issues.

None yet

5 participants