Allow multiple instances of IPCMessageSubscriber in one process #51963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryKuzmenko
force-pushed
the
bugs/49147_ipc_subscriber
branch
from
19d17c6
to
ab41558
Compare
DmitryKuzmenko
force-pushed
the
bugs/49147_ipc_subscriber
branch
from
ab41558
to
710ab50
Compare
dwoz
reviewed
Mar 5, 2019
s0undt3ch
reviewed
Mar 6, 2019
twangboy
approved these changes
Mar 20, 2019
DmitryKuzmenko
force-pushed
the
bugs/49147_ipc_subscriber
branch
from
07810a3
to
cc46e9c
Compare
|
@dwoz, @s0undt3ch are you ok with this now? |
s0undt3ch
approved these changes
Mar 27, 2019
dwoz
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates IPCMessageSubscriber to be instantiated and read simultaneously. To do this I'm introducing an IPCMessageSubscriberService that is the old IPCMessageSubscriber singleton. It's instantiated once and it controls that the socket reading is started once any subscriber want's to read data and stopped when there still no subscribers.
IPCMessageSubscriber is subscribing to data read by the service and reading the data from the async queue not dire
What issues does this PR fix or reference?
Fixes: #49147
Previous Behavior
The second parallel try to read data with IPCMessageSubscriber raises socket error while another reading is in progress.
New Behavior
IPCMessageSubscriber can be used anywhere without taking care of other parts of client code.
Tests written?
Yes, regression.
Commits signed with GPG?
Yes