(Backport 50635) btrfs: add new btrfs state #54962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplanas
force-pushed
the
backport_50635
branch
from
7834e7d
to
b9bd72b
Compare
ghost
requested a review
from 
dwoz
requested changes
Dec 23, 2019
aplanas
force-pushed
the
backport_50635
branch
4 times, most recently
from
76208f8
to
e80a7cd
Compare
aplanas
force-pushed
the
backport_50635
branch
4 times, most recently
from
020e9c0
to
96c3b07
Compare
(cherry picked from commit 237d40d)
When we want to create a subvolume and set is as default, we can use the set_default parameter. The current code will check, for already created subvolumes, if it is actually marked as default, and if not it will be set inside the state. For composability with other states, we sometimes want to avoid the re-set of the default flag for already present subvolumes, as can be that this was change in a later action by another state. (cherry picked from commit 067482e)
|
looks like there are some merge conflicts here @aplanas |
|
This is excellent, the code was already merged in a branch that was using this same code. I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new btrfs state to create and delete subvolumes.
Tests written?
Yes
(backport #50635 and #50801, already merged in develop)