Implement return_retry_tries minion opts and use it for channel.send#59237
Merged
Conversation
lukasraska
requested review from
garethgreenaway
and removed request for
a team
lukasraska
changed the title
3 tasks
garethgreenaway
approved these changes
Jan 13, 2021
s0undt3ch
approved these changes
Jan 17, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements new minion opts
return_retry_trieswhich is used for dynamic configuration of minion return retries attemptsWhat issues does this PR fix or reference?
Fixes #59236
Previous Behavior
Fixed value of 3 would be used
New Behavior
Value from
return_retry_triesis used (with default 3)Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
If this gets merged before #59163 the integration test there could be adapted to test this value change as well.