Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused redis service #45

Merged
merged 1 commit into from
May 4, 2023
Merged

Removed unused redis service #45

merged 1 commit into from
May 4, 2023

Conversation

RyanWalker277
Copy link
Collaborator

Fixes #44

It looks like the uci-api-scheduler-db container may not be needed because none of the services use it. However, the cache container seems to be necessary for the uci-transport-socket service to work properly. Please let me know, if I am mistaken.

@RyanWalker277 RyanWalker277 mentioned this pull request Apr 20, 2023
Closed
27 tasks
@tushar5526
Copy link
Collaborator

Service owners can clarify this. Let's wait on this for now.

@tushar5526
Copy link
Collaborator

tushar5526 commented Apr 25, 2023 •
edited
Loading

@chinmoy12c @pankajjangid05 can you confirm this? Last time I deployed I saw same redis being used to stored and then fetch key-value

@chinmoy12c
Copy link
Member

@chinmoy12c @pankajjangid05 can you confirm this? Last time I deployed I saw same redis being used to stored and then fetch key-value

Both transaction layer (SpringBoot services) as well as uci-api is using 6379 for redis cache.

@tushar5526
Copy link
Collaborator

@chinmoy12c @pankajjangid05 can you confirm this? Last time I deployed I saw same redis being used to stored and then fetch key-value

Both transaction layer (SpringBoot services) as well as uci-api is using 6379 for redis cache.

6379 is going to be common, as we are using internal docker compose network to connect services. hostname is the one which help identify if the cache is same or not.

@RyanWalker277 RyanWalker277 mentioned this pull request May 1, 2023
Closed
@RyanWalker277
Copy link
Collaborator Author

A small update, initially I didn't notice that there is another redis instance named redis in the compose. Just like uci-api-scheduler-db, it also dosen't seem to be used by any other service in the docker-compose. Can anyone confirm whether it is required or not?

@RyanWalker277 RyanWalker277 mentioned this pull request May 3, 2023
Closed
@RyanWalker277 RyanWalker277 changed the title Removed uci-api-scheduler-db service Removed unused redis service May 4, 2023
@tushar5526 tushar5526 changed the base branch from main to dev May 4, 2023 08:00
@gitguardian
Copy link

gitguardian bot commented May 4, 2023 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tushar5526 tushar5526 changed the base branch from dev to main May 4, 2023 08:01
@tushar5526 tushar5526 merged commit a88e9f2 into samagra-comms:main May 4, 2023
tushar5526 pushed a commit that referenced this pull request May 8, 2023
@RyanWalker277
Fusionauth minio setup (#53)
e4c93a0 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* Minio Fusionauth initial setup

* modified kickstart and other changes

* removed unused redis service (#45)

* Minor fixes

* Added manual instructions to readme
tushar5526 pushed a commit that referenced this pull request May 8, 2023
@RyanWalker277
Dev Sync (#57)
d90ccff 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)
tushar5526 pushed a commit to tushar5526/docker-deploy that referenced this pull request May 8, 2023
@RyanWalker277 @tushar5526
Fusionauth minio setup (samagra-comms#53)
2ddbff9 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (samagra-comms#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (samagra-comms#49)

* Minio Fusionauth initial setup

* modified kickstart and other changes

* removed unused redis service (samagra-comms#45)

* Minor fixes

* Added manual instructions to readme
tushar5526 pushed a commit to tushar5526/docker-deploy that referenced this pull request May 8, 2023
@RyanWalker277 @tushar5526
Dev Sync (samagra-comms#57)
4c0e251 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (samagra-comms#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (samagra-comms#49)

* removed unused redis service (samagra-comms#45)
tushar5526 added a commit that referenced this pull request May 8, 2023
@tushar5526 @RyanWalker277
Sync Dev branch (#59)
38cd030 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)

* Changed Cassandra image to bitnami (#54)

* Changed Cassandra image to bitnami

* Removed exposed ports

* Adeed host and modified seeds param

* Minor change

* Added Github token logic (#55)

* Using bind mounts instead of docker volumes (#43)

* changed volumes to bind mounds

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changed mount points

* Minor change

* Removed config and socket files from data

* Changes (#49)

* Fixed mounts for config files and other minor fixes

* Unmounted build folder

* Fusionauth minio setup (#53)

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* Minio Fusionauth initial setup

* modified kickstart and other changes

* removed unused redis service (#45)

* Minor fixes

* Added manual instructions to readme

* Dev Sync (#57)

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)

---------

Co-authored-by: Anvansh <32684077+RyanWalker277@users.noreply.github.com>
tushar5526 pushed a commit that referenced this pull request May 23, 2023
@RyanWalker277
Modified docs and added uci-apis image to docker compose (#64)
509b84c 
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)

* Modified docs and added uci-apis image to docker compose
@RyanWalker277 RyanWalker277 deleted the Fix#44 branch July 1, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove extra Redis caches
3 participants
@RyanWalker277 @tushar5526 @chinmoy12c