Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusionauth minio setup #53

Merged
merged 9 commits into from
May 8, 2023

Conversation

RyanWalker277
Copy link
Collaborator

@RyanWalker277 RyanWalker277 commented May 2, 2023

Fixes #52

This PR completes the setup of minio for OpenId auth through fusionauth. The next PR would completely close #52 by adding a kickstart for automatic creation of a fusionauth application through kickstart

@gitguardian
Copy link

gitguardian bot commented May 2, 2023

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 8bce23b env.dev/minio.env View secret
- Generic Password 8bce23b env.dev/minio.env View secret
- Generic High Entropy Secret 8c1362f .env View secret
- Generic High Entropy Secret 8c1362f env.dev/minio.env View secret
- Generic Password 8c1362f env.dev/minio.env View secret
- Generic High Entropy Secret 8c1362f kickstart/kickstart.json View secret
- Generic High Entropy Secret 1173800 kickstart/kickstart.json View secret
934781 Generic High Entropy Secret c67da57 .env View secret
934781 Generic High Entropy Secret c67da57 .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@RyanWalker277
Copy link
Collaborator Author

Instead of making another PR for the kickstart file, I pushed them in this one itself because initially it seemed that the kickstart would take a lot of time to create but it was completed much before anticipated so I pushed it here itself to close this with one PR only.

@RyanWalker277 RyanWalker277 changed the title Fusinauth minio setup Fusionauth minio setup May 3, 2023
@RyanWalker277 RyanWalker277 mentioned this pull request May 3, 2023
27 tasks
@tushar5526
Copy link
Collaborator

@RyanWalker277 what was the manual step you mentioned in minio? https://github.com/Samagra-Development/workflow/blob/main/docker-compose.yml#L139 take a look through this and check if you can automate minio as well.

@RyanWalker277 RyanWalker277 changed the base branch from main to dev May 6, 2023 08:54
@RyanWalker277
Copy link
Collaborator Author

There is no way of turning on the Claim User Info option in minio through environment variables. I have asked in the forums, will try to find a workaround for that. As of now, this is needed to be manually turned on in order for Oauth to properly work. I have added the instructions in the readme for now.

@tushar5526
Copy link
Collaborator

Seems fine to me. LGTM
@ChakshuGautam let us know if you are aware of any workaround.

@tushar5526 tushar5526 merged commit e4c93a0 into samagra-comms:dev May 8, 2023
1 check passed
tushar5526 pushed a commit to tushar5526/docker-deploy that referenced this pull request May 8, 2023
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (samagra-comms#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (samagra-comms#49)

* Minio Fusionauth initial setup

* modified kickstart and other changes

* removed unused redis service (samagra-comms#45)

* Minor fixes

* Added manual instructions to readme
tushar5526 added a commit that referenced this pull request May 8, 2023
* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)

* Changed Cassandra image to bitnami (#54)

* Changed Cassandra image to bitnami

* Removed exposed ports

* Adeed host and modified seeds param

* Minor change

* Added Github token logic (#55)

* Using bind mounts instead of docker volumes (#43)

* changed volumes to bind mounds

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changed mount points

* Minor change

* Removed config and socket files from data

* Changes (#49)

* Fixed mounts for config files and other minor fixes

* Unmounted build folder

* Fusionauth minio setup (#53)

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* Minio Fusionauth initial setup

* modified kickstart and other changes

* removed unused redis service (#45)

* Minor fixes

* Added manual instructions to readme

* Dev Sync (#57)

* Refactor Fusionauth Forms-DB-GQL Admin Key Configuration (#38)

* modified hasura-gql-key

* Added new enviroment variable for formsdb hasura

* Changes (#49)

* removed unused redis service (#45)

---------

Co-authored-by: Anvansh <32684077+RyanWalker277@users.noreply.github.com>
@RyanWalker277 RyanWalker277 deleted the minio-fusionauth branch June 8, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minio needed for UCI (to be added in docker compose)
2 participants