Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Deprecate in favour of docker/engine-api #238

Closed
bfirsh opened this issue Apr 21, 2016 · 6 comments
Closed

Deprecate in favour of docker/engine-api #238

bfirsh opened this issue Apr 21, 2016 · 6 comments

Comments

@bfirsh
Copy link

bfirsh commented Apr 21, 2016

A bunch of projects use this library, so we probably shouldn't abandon it, but it would perhaps be sensible to suggest people try using https://github.com/docker/engine-api instead.

Is there anything missing from docker/engine-api that would stop users from being able to use it instead of this library?

/cc @samalba @vieux

@vieux
Copy link
Contributor

vieux commented Apr 21, 2016

I would say event management, it's pretty rough in https://github.com/docker/engine-api

@bfirsh
Copy link
Author

bfirsh commented May 26, 2016

@vieux Specifically what about event management is lacking? I want to open an issue against docker/engine-api about this, but not sure exactly what to say. :)

@vieux
Copy link
Contributor

vieux commented May 26, 2016

@bfirsh all the complicated code here https://github.com/samalba/dockerclient/blob/master/dockerclient.go#L472 that parses events and return them via channel, etc...

last time I looked the only thing in engine-api was a GET /events but you have to do most of the rest by hand

@thaJeztah
Copy link

/cc @vdemeester (we were talking about this a while back, re: events)

@vdemeester
Copy link

@bfirsh @vieux yeah, the events in engine-api is pretty bare-metal. I've created a library docker-events (that we use in libcompose) to make it a little useful and was wondering if we should have some code like that in engine-api.

@bfirsh
Copy link
Author

bfirsh commented May 31, 2016

@vieux @vdemeester Thanks, this is really helpful.

@vdemeester Agreed something like that should probably be in engine-api. I've opened docker/engine-api#246 to keep track.

@bfirsh bfirsh closed this as completed May 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants