Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with TypeScript 3 #10

Open
rehmsen opened this issue May 16, 2019 · 2 comments · May be fixed by #11
Open

Not compatible with TypeScript 3 #10

rehmsen opened this issue May 16, 2019 · 2 comments · May be fixed by #11

Comments

@rehmsen
Copy link

rehmsen commented May 16, 2019

fried-twinky depends on tsickle ^0.23.4 [1], which uses getSymbolDisplayBuilder [2], which has been removed in TypeScript 3 [3].

It would be great to try to update to a newer version of tsickle (current is 0.35.0), which does not use getSymbolDisplayBuilder.

[1] https://github.com/samccone/fried-twinkie/blob/master/package.json#L7
[2] https://github.com/angular/tsickle/blob/v0.23.5/src/type-translator.ts#L217
[3] https://github.com/Microsoft/TypeScript-wiki/blob/master/API-Breaking-Changes.md#typescript-30
@samccone
Copy link
Owner

Hey Ole, we can totally update this!

@samccone samccone linked a pull request May 26, 2019 that will close this issue
Open
@samccone
Copy link
Owner

PR in progress here
#11

However we are now hitting a bug in tsickle.
angular/tsickle#1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to typescript 3+ samccone/fried-twinkie
2 participants
@rehmsen @samccone