-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you continue the development of NestJS CRUD? #670
Comments
As I'm using not typeorm but prisma instead, I'm not familiar with above libraries. At least to support those automatic CRUD, you should suggest the detailed specs what you want. |
You are using typeorm or prisma? Not sure I understood. Thanks! |
Not typeorm, but prisma |
You could create the best NestJS CRUD library out there, by forking the existing abandoned one and merging all PRs that address many issues! For example, we would really need this feature to exist in the NestJS CRUD package: Yes, it is in TypeORM but it seems that could do that too, based on your good work in nestia. We are thousands of NestJS developers out there that are left behind. See for example how many weekly downloads exist, despite the package is abandoned: We are all in a great need to see this package supporting many more missing features (like querying in an array and many more, see PRs). Thanks a lot! |
Analyzed the target libraries and understood that your suggestion can be accomplished just by developing an abstract class capsuled in a function, so that need not to make independent library. I will show you the abstract class and its utilization case detaily at tomorrow. For reference, the abstract class would not be affected whatever your ORM is. export function CrudController(props: CrudController.IProps) {
@Controller(props.path)
class CrudController {
....
}
return CrudController;
} |
@afilp Here is the example. As you can see, no special library required. Just copy and paste the abstract controller class and customize for your use case.
Github Actions Result: https://github.com/samchon/nestia-auto-crud-example/actions/runs/6677610452/job/18147796260 |
Thanks @samchon , I am not sure I get this, is what you propose a replacement of the NestJS CRUD library? |
If you need additional features, define them into the abstract class. |
Ok, if we were to migrate from that package to yours, do you have utilities for easy CRUD development? (with all the filters that they support, etc.?). Thanks a lot! |
I have not abstracted such detailly because I think that each API has each story. Also, I do not design database table to be correspondent with DTO schema to be 1:1 relationship. I think that as basic principle of database and DTO structures are different, they've to be different. Furthermore, as I'm using Prisma ORM, which supports type safe APIs, so that taking advantages from auto-completions with type hints, I don't need such features. Therefore, I can't understand why such features are required. It is your mind that defining such deeply abstracted abstract class, but I won't support it. Anyway, I've just made utility functions like pagination case of below.
|
Feature Request
It appears that due to your passion and deep knowledge you are the perfect developer to create the best NestJS CRUD library out there.
So, a humble request, can you please, please fork this abandoned NestJS CRUD library and continue its development? It used to be a great library and still is, but has some problems now as the years passed.
nestjsx/crud#710
P.S. This is a fork with some new commits but with no feature development, just trying to be compatible with the latest NestJS version:
https://github.com/gid-oss/dataui-nestjs-crud#readme
The text was updated successfully, but these errors were encountered: