Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 7 omniauth #13

Merged
merged 20 commits into from
Oct 9, 2019
Merged

Milestone 7 omniauth #13

merged 20 commits into from
Oct 9, 2019

Conversation

samgaco
Copy link
Owner

@samgaco samgaco commented Oct 7, 2019


Milestone 1

#2

Milestone 2

#4

Milestone 3

#5
(it got finally approved after a rectification by the last TSE to review in that PR)

Milestone 4

#9

Milestone 5

#10

Milestone 6

#11

Milestone 7

  • Omniauth implementation

Rubocop doesn't get activated in the pull request:

I am running the linters locally because of the reasons mentioned in my last comment in milestone 2 ( #4 ).

The offenses remaining I cannot solve them, they all concern the same thing and researching it seems like they could be bugs


Working alone:

I am working on this project alone, allowed by student success.

Testing

Execute

bundle exec rspec

@samgaco
Copy link
Owner Author

samgaco commented Oct 7, 2019

The names of the commits come from the multiple attempts at deploying to Heroku. None of them got omniauth working

https://pentalingo.herokuapp.com/

@samgaco
Copy link
Owner Author

samgaco commented Oct 7, 2019

these are heroku logs -t

2019-10-04T18:57:43.097057+00:00 app[web.1]: Puma starting in single mode...
2019-10-04T18:57:43.097059+00:00 app[web.1]: * Version 3.12.1 (ruby 2.6.1-p33), codename: Llamas in Pajamas
2019-10-04T18:57:43.097066+00:00 app[web.1]: * Min threads: 5, max threads: 5
2019-10-04T18:57:43.097069+00:00 app[web.1]: * Environment: production
2019-10-04T18:57:43.097071+00:00 app[web.1]: * Listening on tcp://0.0.0.0:55401
2019-10-04T18:57:43.097073+00:00 app[web.1]: Use Ctrl-C to stop
2019-10-04T18:57:43.097082+00:00 app[web.1]: I, [2019-10-04T18:57:43.096853 #4]  INFO -- : [9cad4925-4b28-41dd-9fdc-9e36ec5f0ca4] Started GET "/users/auth/facebook/callback" for 185.20.6.108 at 2019-10-04 18:57:43 +0000
2019-10-04T18:57:43.097584+00:00 app[web.1]: I, [2019-10-04T18:57:43.097497 #4]  INFO -- omniauth: (facebook) Callback phase initiated.
2019-10-04T18:57:43.103826+00:00 app[web.1]: E, [2019-10-04T18:57:43.103745 #4] ERROR -- omniauth: (facebook) Authentication failure! no_authorization_code: OmniAuth::Strategies::Facebook::NoAuthorizationCodeError, must pass either a `code` (via URL or by an `fbsr_XXX` signed request cookie)
2019-10-04T18:57:43.105171+00:00 app[web.1]: I, [2019-10-04T18:57:43.105024 #4]  INFO -- : [9cad4925-4b28-41dd-9fdc-9e36ec5f0ca4] Processing by Users::OmniauthCallbacksController#failure as HTML
2019-10-04T18:57:43.107538+00:00 app[web.1]: I, [2019-10-04T18:57:43.107423 #4]  INFO -- : [9cad4925-4b28-41dd-9fdc-9e36ec5f0ca4] Redirected to https://pentalingo.herokuapp.com/
2019-10-04T18:57:43.107930+00:00 app[web.1]: I, [2019-10-04T18:57:43.107717 #4]  INFO -- : [9cad4925-4b28-41dd-9fdc-9e36ec5f0ca4] Completed 302 Found in 2ms
2019-10-04T19:32:40.330613+00:00 heroku[web.1]: Idling
2019-10-04T19:32:40.352864+00:00 heroku[web.1]: State changed from up to down
2019-10-04T19:32:44.640931+00:00 heroku[web.1]: Stopping all processes with SIGTERM
2019-10-04T19:32:44.671452+00:00 app[web.1]: - Gracefully stopping, waiting for requests to finish
2019-10-04T19:32:44.689659+00:00 app[web.1]: === puma shutdown: 2019-10-04 19:32:44 +0000 ===
2019-10-04T19:32:44.689715+00:00 app[web.1]: - Goodbye!
2019-10-04T19:32:44.690011+00:00 app[web.1]: Exiting
2019-10-04T19:32:45.037982+00:00 heroku[web.1]: Process exited with status 143
2019-10-07T10:38:58.000000+00:00 app[api]: Build started by user samuelgarciacompanys@gmail.com
2019-10-07T10:39:30.852277+00:00 app[api]: Deploy 39059860 by user samuelgarciacompanys@gmail.com
2019-10-07T10:39:31.052365+00:00 heroku[web.1]: State changed from down to starting
2019-10-07T10:39:30.852277+00:00 app[api]: Release v9 created by user samuelgarciacompanys@gmail.com
2019-10-07T10:39:40.548138+00:00 heroku[web.1]: Starting process with command `bin/rails server -p 53518 -e production`
2019-10-07T10:39:41.000000+00:00 app[api]: Build succeeded
2019-10-07T10:39:51.991786+00:00 heroku[web.1]: State changed from starting to up
2019-10-07T10:42:26.679176+00:00 app[api]: Starting process with command `bundle exec rake db:version` by user samuelgarciacompanys@gmail.com
2019-10-07T10:42:33.862129+00:00 heroku[run.5947]: State changed from starting to up
2019-10-07T10:42:33.858055+00:00 heroku[run.5947]: Awaiting client
2019-10-07T10:42:33.899374+00:00 heroku[run.5947]: Starting process with command `bundle exec rake db:version`
2019-10-07T10:42:42.119711+00:00 heroku[run.5947]: State changed from up to complete
2019-10-07T10:42:42.095775+00:00 heroku[run.5947]: Process exited with status 0
2019-10-07T10:42:48.602624+00:00 heroku[router]: at=info method=GET path="/" host=pentalingo.herokuapp.com request_id=2caa62b1-5fe3-48b4-b429-6f4fb873ddcd fwd="46.24.93.212" dyno=web.1 connect=0ms service=167ms status=302 bytes=1037 protocol=https
2019-10-07T10:42:48.804260+00:00 app[web.1]: I, [2019-10-07T10:42:48.804136 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2] Started GET "/users/sign_in" for 46.24.93.212 at 2019-10-07 10:42:48 +0000
2019-10-07T10:42:48.811375+00:00 app[web.1]: I, [2019-10-07T10:42:48.810876 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2] Processing by Devise::SessionsController#new as HTML
2019-10-07T10:42:49.176280+00:00 app[web.1]: I, [2019-10-07T10:42:49.176132 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2]   Rendering devise/sessions/new.html.erb within layouts/application
2019-10-07T10:42:49.207469+00:00 app[web.1]: I, [2019-10-07T10:42:49.202832 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2]   Rendered devise/shared/_links.html.erb (2.4ms)
2019-10-07T10:42:49.207943+00:00 app[web.1]: I, [2019-10-07T10:42:49.207610 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2]   Rendered devise/sessions/new.html.erb within layouts/application (31.3ms)
2019-10-07T10:42:49.213224+00:00 app[web.1]: I, [2019-10-07T10:42:49.213134 #4]  INFO -- : [a3fd4f07-29de-4224-9c0f-5a2392ad1eb2] Completed 200 OK in 401ms (Views: 48.7ms | ActiveRecord: 89.8ms)
2019-10-07T10:42:48.445638+00:00 app[web.1]: => Booting Puma
2019-10-07T10:42:48.445656+00:00 app[web.1]: => Rails 5.2.3 application starting in production
2019-10-07T10:42:48.445659+00:00 app[web.1]: => Run `rails server -h` for more startup options
2019-10-07T10:42:48.445661+00:00 app[web.1]: Puma starting in single mode...
2019-10-07T10:42:48.445663+00:00 app[web.1]: * Version 3.12.1 (ruby 2.6.1-p33), codename: Llamas in Pajamas
2019-10-07T10:42:48.445665+00:00 app[web.1]: * Min threads: 5, max threads: 5
2019-10-07T10:42:48.445668+00:00 app[web.1]: * Environment: production
2019-10-07T10:42:48.445670+00:00 app[web.1]: * Listening on tcp://0.0.0.0:53518
2019-10-07T10:42:48.445672+00:00 app[web.1]: Use Ctrl-C to stop
2019-10-07T10:42:48.445684+00:00 app[web.1]: I, [2019-10-07T10:42:48.445531 #4]  INFO -- : [2caa62b1-5fe3-48b4-b429-6f4fb873ddcd] Started GET "/" for 46.24.93.212 at 2019-10-07 10:42:48 +0000
2019-10-07T10:42:48.463096+00:00 app[web.1]: I, [2019-10-07T10:42:48.462977 #4]  INFO -- : [2caa62b1-5fe3-48b4-b429-6f4fb873ddcd] Processing by HomeController#index as HTML
2019-10-07T10:42:48.498056+00:00 app[web.1]: I, [2019-10-07T10:42:48.497943 #4]  INFO -- : [2caa62b1-5fe3-48b4-b429-6f4fb873ddcd] Completed 401 Unauthorized in 34ms
2019-10-07T10:42:49.220589+00:00 heroku[router]: at=info method=GET path="/users/sign_in" host=pentalingo.herokuapp.com request_id=a3fd4f07-29de-4224-9c0f-5a2392ad1eb2 fwd="46.24.93.212" dyno=web.1 connect=0ms service=419ms status=200 bytes=3730 protocol=https
2019-10-07T10:42:50.359055+00:00 heroku[router]: at=info method=GET path="/assets/application-2f6d95aed67bdc67673549691ec91f8f02cc5c9718b66b47a9c38caffa8d0ab3.css" host=pentalingo.herokuapp.com request_id=fd03f92c-62d4-4497-ae1a-77aa178d9ce4 fwd="46.24.93.212" dyno=web.1 connect=0ms service=11ms status=200 bytes=32943 protocol=https
2019-10-07T10:42:50.377383+00:00 heroku[router]: at=info method=GET path="/assets/application-c9e105b26f7759a4c01ba53c33d87903d5dc8026ddd6ca19c730fc1afde866dd.js" host=pentalingo.herokuapp.com request_id=75eb60b0-40c7-4d66-8b58-f08315bd152a fwd="46.24.93.212" dyno=web.1 connect=0ms service=12ms status=200 bytes=69832 protocol=https
2019-10-07T10:42:50.841151+00:00 heroku[router]: at=info method=GET path="/assets/pentalogo-9c00280152027982c4384805f37d3aeaaf2dda4687487558d1b172af1a5998b8.png" host=pentalingo.herokuapp.com request_id=005cddd6-3386-4d2f-ab27-efe264dab2d8 fwd="46.24.93.212" dyno=web.1 connect=0ms service=31ms status=200 bytes=1139877 protocol=https
2019-10-07T10:42:54.586959+00:00 heroku[router]: at=info method=GET path="/favicon.ico" host=pentalingo.herokuapp.com request_id=9b2d7c66-6194-49f1-abe1-b082c2f2a941 fwd="46.24.93.212" dyno=web.1 connect=0ms service=4ms status=200 bytes=143 protocol=https
2019-10-07T10:42:54.702968+00:00 heroku[router]: at=info method=GET path="/users/auth/facebook" host=pentalingo.herokuapp.com request_id=1e3de16e-5a05-40f9-80b4-d9cfca82f029 fwd="46.24.93.212" dyno=web.1 connect=0ms service=56ms status=302 bytes=1189 protocol=https
2019-10-07T10:42:55.164420+00:00 app[web.1]: I, [2019-10-07T10:42:55.164291 #4]  INFO -- : [5b5341f1-9c74-4830-afcb-873e5490501a] Started GET "/users/auth/facebook" for 46.24.93.212 at 2019-10-07 10:42:55 +0000
2019-10-07T10:42:55.164904+00:00 app[web.1]: I, [2019-10-07T10:42:55.164841 #4]  INFO -- omniauth: (facebook) Request phase initiated.
2019-10-07T10:42:54.649991+00:00 app[web.1]: I, [2019-10-07T10:42:54.649878 #4]  INFO -- : [1e3de16e-5a05-40f9-80b4-d9cfca82f029] Started GET "/users/auth/facebook" for 46.24.93.212 at 2019-10-07 10:42:54 +0000
2019-10-07T10:42:54.650452+00:00 app[web.1]: I, [2019-10-07T10:42:54.650382 #4]  INFO -- omniauth: (facebook) Request phase initiated.
2019-10-07T10:42:55.165696+00:00 heroku[router]: at=info method=GET path="/users/auth/facebook" host=pentalingo.herokuapp.com request_id=5b5341f1-9c74-4830-afcb-873e5490501a fwd="46.24.93.212" dyno=web.1 connect=0ms service=9ms status=302 bytes=1193 protocol=https
2019-10-07T10:42:56.280281+00:00 app[web.1]: I, [2019-10-07T10:42:56.280168 #4]  INFO -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] Started GET "/users/auth/facebook/callback?code=AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us&state=ddb18a986d38f507722f3020a42c16d803907225084f91c4" for 46.24.93.212 at 2019-10-07 10:42:56 +0000
2019-10-07T10:42:56.282214+00:00 app[web.1]: I, [2019-10-07T10:42:56.282136 #4]  INFO -- omniauth: (facebook) Callback phase initiated.
2019-10-07T10:42:56.621799+00:00 app[web.1]: I, [2019-10-07T10:42:56.621657 #4]  INFO -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] Processing by Users::OmniauthCallbacksController#facebook as HTML
2019-10-07T10:42:56.628397+00:00 app[web.1]: I, [2019-10-07T10:42:56.627363 #4]  INFO -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3]   Parameters: {"code"=>"AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us", "state"=>"ddb18a986d38f507722f3020a42c16d803907225084f91c4"}
2019-10-07T10:42:56.736807+00:00 app[web.1]: I, [2019-10-07T10:42:56.736675 #4]  INFO -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] Completed 500 Internal Server Error in 107ms (ActiveRecord: 22.6ms)
2019-10-07T10:42:56.764353+00:00 app[web.1]: F, [2019-10-07T10:42:56.764176 #4] FATAL -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3]
2019-10-07T10:42:56.837544+00:00 app[web.1]: F, [2019-10-07T10:42:56.837387 #4] FATAL -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR:  column users.provider does not exist
2019-10-07T10:42:56.837549+00:00 app[web.1]: LINE 1: SELECT  "users".* FROM "users" WHERE "users"."provider" = $1...
2019-10-07T10:42:56.837552+00:00 app[web.1]: ^
2019-10-07T10:42:56.837555+00:00 app[web.1]: : SELECT  "users".* FROM "users" WHERE "users"."provider" = $1 AND "users"."uid" = $2 ORDER BY "users"."id" ASC LIMIT $3):
2019-10-07T10:42:56.839088+00:00 app[web.1]: F, [2019-10-07T10:42:56.839011 #4] FATAL -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3]
2019-10-07T10:42:56.839799+00:00 app[web.1]: F, [2019-10-07T10:42:56.839729 #4] FATAL -- : [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] app/models/user.rb:54:in `from_omniauth'
2019-10-07T10:42:56.839802+00:00 app[web.1]: [ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3] app/controllers/users/omniauth_callbacks_controller.rb:3:in `facebook'
2019-10-07T10:42:56.845512+00:00 heroku[router]: at=info method=GET path="/users/auth/facebook/callback?code=AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us&state=ddb18a986d38f507722f3020a42c16d803907225084f91c4" host=pentalingo.herokuapp.com request_id=ff9d18f8-3a28-45bd-ad7a-c2d18257f0b3 fwd="46.24.93.212" dyno=web.1 connect=0ms service=572ms status=500 bytes=1827 protocol=https
2019-10-07T10:44:20.302191+00:00 app[web.1]: I, [2019-10-07T10:44:20.302072 #4]  INFO -- : [66d7021b-cf81-4349-842a-e197fb915b1c] Started GET "/users/auth/facebook/callback?code=AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us&state=ddb18a986d38f507722f3020a42c16d803907225084f91c4" for 46.24.93.212 at 2019-10-07 10:44:20 +0000
2019-10-07T10:44:20.302616+00:00 app[web.1]: I, [2019-10-07T10:44:20.302551 #4]  INFO -- omniauth: (facebook) Callback phase initiated.
2019-10-07T10:44:20.401418+00:00 app[web.1]: E, [2019-10-07T10:44:20.401227 #4] ERROR -- omniauth: (facebook) Authentication failure! invalid_credentials: OAuth2::Error, {"message"=>"This authorization code has been used.", "type"=>"OAuthException", "code"=>100, "fbtrace_id"=>"An_I2bZd6qfoaZ-7WW0tapt"}:
2019-10-07T10:44:20.401427+00:00 app[web.1]: {"error":{"message":"This authorization code has been used.","type":"OAuthException","code":100,"fbtrace_id":"An_I2bZd6qfoaZ-7WW0tapt"}}
2019-10-07T10:44:20.402291+00:00 app[web.1]: I, [2019-10-07T10:44:20.402191 #4]  INFO -- : [66d7021b-cf81-4349-842a-e197fb915b1c] Processing by Users::OmniauthCallbacksController#failure as HTML
2019-10-07T10:44:20.402383+00:00 app[web.1]: I, [2019-10-07T10:44:20.402303 #4]  INFO -- : [66d7021b-cf81-4349-842a-e197fb915b1c]   Parameters: {"code"=>"AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us", "state"=>"ddb18a986d38f507722f3020a42c16d803907225084f91c4"}
2019-10-07T10:44:20.403199+00:00 app[web.1]: I, [2019-10-07T10:44:20.403132 #4]  INFO -- : [66d7021b-cf81-4349-842a-e197fb915b1c] Redirected to https://pentalingo.herokuapp.com/
2019-10-07T10:44:20.403467+00:00 app[web.1]: I, [2019-10-07T10:44:20.403390 #4]  INFO -- : [66d7021b-cf81-4349-842a-e197fb915b1c] Completed 302 Found in 1ms (ActiveRecord: 0.0ms)
2019-10-07T10:44:20.548418+00:00 app[web.1]: I, [2019-10-07T10:44:20.548313 #4]  INFO -- : [a822759a-ae45-44de-8cb1-53f331bd2646] Started GET "/" for 46.24.93.212 at 2019-10-07 10:44:20 +0000
2019-10-07T10:44:20.549928+00:00 app[web.1]: I, [2019-10-07T10:44:20.549850 #4]  INFO -- : [a822759a-ae45-44de-8cb1-53f331bd2646] Processing by HomeController#index as HTML
2019-10-07T10:44:20.407700+00:00 heroku[router]: at=info method=GET path="/users/auth/facebook/callback?code=AQC7rBW4qcVtA0auZ4uFIKoPCznAdFYBcrG-xcXfZmU3dB48SLFQnCNHtnWsXXUCQ-ldBoLXPZAkGQ9oi0UO9CfJkHSYyfq-mPT-tCObB5_Ihe3iKivHVk03Gu4blPHL1TX-vy7ECo1JHSI-sSEoI0pw7W_nLI-TLDzx0tb0e-PaImprUrfPB8m5GJFhTZX_xGoDGgdhTvoAIGmNiJDtDr08UNG52np311qFgmFfNMXx5j-y7TyfAPv50ROcpc-quVSWzqdbYI6QOJtNcUGaRKNEqR2ga6e_kq5w3LaYnvRsok0fnomNuTI5_cPDjrNwTR9NYVTH7r-dNZYwt4SCA0Us&state=ddb18a986d38f507722f3020a42c16d803907225084f91c4" host=pentalingo.herokuapp.com request_id=66d7021b-cf81-4349-842a-e197fb915b1c fwd="46.24.93.212" dyno=web.1 connect=1ms service=111ms status=302 bytes=865 protocol=https
2019-10-07T10:44:20.571079+00:00 heroku[router]: at=info method=GET path="/" host=pentalingo.herokuapp.com request_id=a822759a-ae45-44de-8cb1-53f331bd2646 fwd="46.24.93.212" dyno=web.1 connect=1ms service=24ms status=302 bytes=827 protocol=https
2019-10-07T10:44:20.561292+00:00 app[web.1]: I, [2019-10-07T10:44:20.561174 #4]  INFO -- : [a822759a-ae45-44de-8cb1-53f331bd2646] Completed 401 Unauthorized in 1ms (ActiveRecord: 0.0ms)
2019-10-07T10:44:20.772322+00:00 app[web.1]: I, [2019-10-07T10:44:20.772199 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e] Started GET "/users/sign_in" for 46.24.93.212 at 2019-10-07 10:44:20 +0000
2019-10-07T10:44:20.773830+00:00 app[web.1]: I, [2019-10-07T10:44:20.773694 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e] Processing by Devise::SessionsController#new as HTML
2019-10-07T10:44:20.796980+00:00 app[web.1]: I, [2019-10-07T10:44:20.796837 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e]   Rendering devise/sessions/new.html.erb within layouts/application
2019-10-07T10:44:20.823449+00:00 heroku[router]: at=info method=GET path="/users/sign_in" host=pentalingo.herokuapp.com request_id=75705496-03fb-40de-9136-98083e7a1d5e fwd="46.24.93.212" dyno=web.1 connect=1ms service=53ms status=200 bytes=3504 protocol=https
2019-10-07T10:44:20.820153+00:00 app[web.1]: I, [2019-10-07T10:44:20.819872 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e]   Rendered devise/shared/_links.html.erb (0.7ms)
2019-10-07T10:44:20.820171+00:00 app[web.1]: I, [2019-10-07T10:44:20.820048 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e]   Rendered devise/sessions/new.html.erb within layouts/application (23.0ms)
2019-10-07T10:44:20.821358+00:00 app[web.1]: I, [2019-10-07T10:44:20.821278 #4]  INFO -- : [75705496-03fb-40de-9136-98083e7a1d5e] Completed 200 OK in 47ms (Views: 27.8ms | ActiveRecord: 0.0ms)
2019-10-07T10:44:21.464062+00:00 heroku[router]: at=info method=GET path="/favicon.ico" host=pentalingo.herokuapp.com request_id=de3353dc-1fd1-4b38-a51a-75447ca7e4ab fwd="46.24.93.212" dyno=web.1 connect=1ms service=6ms status=304 bytes=48 protocol=https

Copy link

@Oghenebrume50 Oghenebrume50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samgaco this works, great work 👏 , there seems to be an issue with the config files,
rails aborted! SyntaxError: /home/socialnetwork/config/initializers/devise.rb:301: syntax error, unexpected end /home/socialnetwork/config/environment.rb:5:in

'
/home/socialnetwork/bin/rails:9:in <top (required)>' /home/socialnetwork/bin/spring:15:in <top (required)>'`
it throws an error whenever I try to migrate, is this working on Heroku?
I had to use a different config file in initialize/devise.rb before I could run it.
Please check this, fix and submit for re-review 🙏

@samgaco
Copy link
Owner Author

samgaco commented Oct 8, 2019

Hi @Oghenebrume50

Yes, it is working on Heroku. I have fixed the issue. I re-submit for a review

Copy link

@efrapp efrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @samgaco 👋

Good job on this milestone. The sign-in with Facebook is working and the problem with the migrations was fixed. You can marge your work and continue with the final milestone 👍

Status: Approved

@samgaco samgaco merged commit 3b96c47 into development Oct 9, 2019
@samgaco samgaco mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants