-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 7 omniauth #13
Conversation
The names of the commits come from the multiple attempts at deploying to Heroku. None of them got omniauth working |
these are
|
…writting devise,added fields to the info fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samgaco this works, great work 👏 , there seems to be an issue with the config files,
rails aborted! SyntaxError: /home/socialnetwork/config/initializers/devise.rb:301: syntax error, unexpected end /home/socialnetwork/config/environment.rb:5:in
/home/socialnetwork/bin/rails:9:in
<top (required)>' /home/socialnetwork/bin/spring:15:in
<top (required)>'`it throws an error whenever I try to migrate, is this working on Heroku?
I had to use a different config file in initialize/devise.rb before I could run it.
Please check this, fix and submit for re-review 🙏
Yes, it is working on Heroku. I have fixed the issue. I re-submit for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samgaco 👋
Good job on this milestone. The sign-in with Facebook is working and the problem with the migrations was fixed. You can marge your work and continue with the final milestone 👍
Status: Approved
Milestone 1
#2
Milestone 2
#4
Milestone 3
#5
(it got finally approved after a rectification by the last TSE to review in that PR)
Milestone 4
#9
Milestone 5
#10
Milestone 6
#11
Milestone 7
Rubocop doesn't get activated in the pull request:
I am running the linters locally because of the reasons mentioned in my last comment in milestone 2 ( #4 ).
The offenses remaining I cannot solve them, they all concern the same thing and researching it seems like they could be bugs
Working alone:
I am working on this project alone, allowed by student success.
Testing
Execute