Milestone 5 friendshipv1

[samgaco]

Milestone 1

#2

Milestone 2

#4

Milestone 3

#5
(it got finally approved after a rectification by the last TSE to review in that PR)

Milestone 4

#9

---

Milestone 5

• Created a model with associations and all requested features for friendships.
• Remember about unit and integrations tests!

---

Rubocop doesn't get activated in the pull request:

I am running the linters locally because of the reasons mentioned in my last comment in milestone 2 ( #4 ).

The offenses remaining I cannot solve them, they all concern the same thing and researching it seems like they could be bugs

---

Working alone:

I am working on this project alone, allowed by student success.

[mosaaleb]

Well done @samgaco 👏

• sender sent a friend request to receiver. reciever can't send a friend request to sender.

We can achieve this by adding interchangeable validation to check if the [user_id, friend_id] or [friend_id, user_id] exist in the friendship table. please take a look at this example

• [OPTIONAL] Previous step adds model validations to friendships uniqueness. I would suggest to add interchangeable DB validations. You need to know first why DB validations are important why.
  My previous code partner wrote an article on how to achieve this.

• Please see my comments below.

Please handle these requirements and submit a new code review.

Happy Coding 💻

[mosaaleb]

That's perfect way to handle friendships and inverse friendships 👏

[mosaaleb]

• [OPTIONAL] There is some sort of logic duplication in these scopes. For example:
• invitation_requests scope can be achieved with user.passive_friendships
• invitation_sent scope can also be achieved with user.active_friendships

I suggest to use association because defining associations can give your number of other helper methods like passive_friendship_ids which will return an array of friendships records ids associated with a particular user.

Also passive_friendships return value acts like an array provided also with the helper methods (though it is not actually an array), so you can do something like user.passive_friendships << [friendship_object].

[samgaco]

how could I use associations for that purpose?

[mosaaleb]

@samgaco Sorry, what do you mean?

[mosaaleb]

• Views should not perform any application logic. We can replace User.find(post.user_id).name with just post.user.name

[samgaco]

solved

[mosaaleb]

• This view file is bloated with functionality that doesn't belong to it.
  (current_user.friendships.where('user_id = :id OR friend_id = :id', id: user.id).where("status = (?)", true).exists? ) belongs to model. So we can create accepted_friendship scope whose status is true and make it available in the controller so it will be availble in the views. Views aren't supposed to hit the database to get data, it just displays the data provided by its corresponding controller.

[samgaco]

Well done @samgaco

• sender sent a friend request to receiver. reciever can't send a friend request to sender.

We can achieve this by adding interchangeable validation to check if the [user_id, friend_id] or [friend_id, user_id] exist in the friendship table. please take a look at this example

• [OPTIONAL] Previous step adds model validations to friendships uniqueness. I would suggest to add interchangeable DB validations. You need to know first why DB validations are important why.
  My previous code partner wrote an article on how to achieve this.
• Please see my comments below.

Please handle these requirements and submit a new code review.

Happy Coding

Changes made as suggested

[Oghenebrume50]

Hi @samgaco good work 👏 this is approved, please move to the next milestone