Milestone 4 comments and likes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show more than 1, and redirect to a page for the post with its comments, when someone wants to see more
efrapp
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Hi @samgaco and @Forison!
Great job so far. All the checkpoints for milestone 4 are met. Please, check the suggestion below and you can continue with the next milestone 👍
Optional suggestions
- please don't use reserved words for the dev database, currently, you are using
postgres.
I think the problem with Stickler is because you didn't add it at the beginning of the project so I don't know if it is possible to fix it now.
Status: Approved
This was referenced Oct 1, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone 1
#2
Milestone 2
#4
Milestone 3
#5
(it got finally approved after a rectification by the last TSE to review in that PR)
Milestone 4
Rubocop doesn't get activated in the pull request:
I am running the linters locally because of the reasons mentioned in my last comment in milestone 2 ( #4 ).
The offenses remaining I cannot solve them, they all concern the same thing and researching it seems like they could be bugs
Working alone:
I am working on this project alone, allowed by student success.