Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service worker silently fails with no error if origin is not trusted #10

Closed
JoshuaCWebDeveloper opened this issue Oct 8, 2022 · 2 comments
Closed

Service worker silently fails with no error if origin is not trusted #10

JoshuaCWebDeveloper opened this issue Oct 8, 2022 · 2 comments

Comments

@JoshuaCWebDeveloper
Copy link
Collaborator

If http://samizdapp.local is not added to the insecure origin browser flag (or if the flag is disabled), then the service worker will fail to install with no error either in the UI or in the browser console. (the loading gif just keeps spinning).

Ideally, we'd be able to detect when the origin isn't being treated as secure and broadcast a message in the UI.

At the very least, we should log the status of the service worker (whether it is installed or not) and log an error if it doesn't get installed by the browser.
@JoshuaCWebDeveloper
Copy link
Collaborator Author

In the athena gateway-client app, the error "No service worker support detected. Use modern browser." is logged.

@JoshuaCWebDeveloper JoshuaCWebDeveloper mentioned this issue Oct 18, 2022
Merged
@JoshuaCWebDeveloper
Copy link
Collaborator Author

Fixed by samizdapp/athena#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaCWebDeveloper