Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened access to Java 11 language features. #105

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

sampottinger
Copy link
Owner

@sampottinger sampottinger commented Aug 28, 2019

Moved from Java 8 to Java 11 for Compiler and JDT. Also added gramatical support for local variable type inference (var). Includes minor edits to existing parser tests to ensure full test suite is in use.

Moved from Java 8 to Java 11 for Compiler and JDT. Also added gramatical support for local variable type inference (var).
@sampottinger sampottinger self-assigned this Aug 28, 2019
@sampottinger
Copy link
Owner Author

Fixes #104.

@sampottinger
Copy link
Owner Author

Important note ... I ended up including grammatical support for var but, for simplicity, it is potentially more permissive than the Java language definition. That said, misuse is still captured in the JDT instead of the preprocessor.

@dzaima
Copy link

dzaima commented Aug 28, 2019

Would/could this in any way interfere with the fact that Android mode is stuck at ~Java 8 (besides not being able to use 11's features), or is it completely independent from these changes?

@sampottinger
Copy link
Owner Author

sampottinger commented Aug 28, 2019

Hey there! It don't think it will prevent android mode from working but it does mean that some language features will not be available to users on android mode (though that's also somewhat true of Java 8). So, if you used a language feature beyond Java 7 that wasn't supported in Android, you'd probably find out in the android build step instead of from the pre-processor.

@sampottinger
Copy link
Owner Author

As a side note... hopefully android moves to Java 11 (or at least proper Java 8) at some point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants