IO refactor #3
Merged
IO refactor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase automated testing to support some of the larger PRs (processing#5753), moved some image and input logic to strategies under a new core.util module so that they can be unit tested without testing with a full PApplet. Will soon refactor out other places where java hits some of the more systems oriented calls like read bytes and create output as well as image save logic for consistency. Tests and JavaDoc pending.
sampottinger
commented
Jan 22, 2019
sampottinger
added a commit
that referenced
this pull request
Aug 7, 2019
sampottinger
added a commit
that referenced
this pull request
Aug 7, 2019
sampottinger
added a commit
that referenced
this pull request
Aug 7, 2019
sampottinger
added a commit
that referenced
this pull request
Aug 9, 2019
Re-introduced base 64 image loading tests from image path despite the rollback of sampottinger/processing #3. There were some issues with the API migration earlier and would like to leave this in if possible.
sampottinger
added a commit
that referenced
this pull request
Aug 10, 2019
Revert of sampottinger/processing #3 for the antlr branch.
sampottinger
added a commit
that referenced
this pull request
Aug 10, 2019
Revert of sampottinger/processing #3 for java11 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For processing#5753, added in testing and some Java 11 fixes for file IO with a lot of work specifically on images.