Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS compile errors #148

Closed
ivanvermeyen opened this issue Jan 23, 2016 · 6 comments
Closed

SCSS compile errors #148

ivanvermeyen opened this issue Jan 23, 2016 · 6 comments
Assignees
Labels

Comments

@ivanvermeyen
Copy link
Contributor

Hi,

Your player looks absolutely awesome!

I was trying to compile your SCSS with Gulp and got some errors.
It seems there are 2 issues in "plyr.scss":

On line 49 "@gray-dark" is not recognized. I changed this to "$plyr-gray-dark".

On line 62, there is a semicolon before "!default'. I removed this.

Now it compiles without errors.

@ivanvermeyen
Copy link
Contributor Author

On line 390 the reference to "plyr__progress" is faulty: "&--progress" should be "&__progress".

@sampotts
Copy link
Owner

Thanks mate, I'll fix these up. 👍

Oddly I do test by running the gulp sass task but it didn't throw any errors.

@sampotts sampotts added the Bug label Jan 23, 2016
@sampotts sampotts reopened this Jan 23, 2016
@sampotts sampotts self-assigned this Jan 23, 2016
@ivanvermeyen
Copy link
Contributor Author

Thanks! 👍

Also, in relation to #149, if I use the SASS compiled CSS, the controls don't hide at all. If I find out why, I'll let you know. What I described in #149 is tested with the dist/css version.

@sampotts
Copy link
Owner

Cool mate. Looking at #149 now.

@ivanvermeyen
Copy link
Contributor Author

Oops wrong button :)

@sampotts
Copy link
Owner

No worries, just pushed the fixes 👍

@SexySale
Copy link

Hi @sampotts

Great work on Plyr! I am enthusiastic about this project 👍
Keep up with great work...

I have one Sass compile error to report:
plyr.scss there is missing property that is causing compile error.
Can you look at that?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants