Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox] Unlisted vimeo videos missing hash parameter #2606

Open
despecial opened this issue Jan 24, 2023 · 2 comments
Open

[Lightbox] Unlisted vimeo videos missing hash parameter #2606

despecial opened this issue Jan 24, 2023 · 2 comments

Comments

@despecial
Copy link

Expected behaviour

Play unlisted vimeo video in lightbox (glightbox)

Actual behaviour

Lightbox opens and Vimeo response is that the video does not exist.
In the iframe source, there is no "h" parameter, which is needed for unlisted videos.

Steps to reproduce

Example url: https://vimeo.com/791813674/2c9cfc5030
Code: https://jsfiddle.net/despecial/1s5kLpug/1/

Console errors (if any)

No errors in console.
According to the Lightbox devs they send the full url via data-plyr-embed-id to Plyr.
https://github.com/biati-digital/glightbox/blob/master/dist/js/glightbox.js#L1816

Link to where the bug is happening

See https://jsfiddle.net/despecial/1s5kLpug/1/

@despecial
Copy link
Author

Tested #2505 and (without the alert) it does indeed work.
Can you please merge it?

@DowleyDeveloped
Copy link

Can this please be merged? @sampotts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants