Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you want me to add GitHub Actions? #88

Open
KTibow opened this issue Nov 15, 2020 · 5 comments
Open

Do you want me to add GitHub Actions? #88

KTibow opened this issue Nov 15, 2020 · 5 comments

Comments

@KTibow
Copy link
Contributor

KTibow commented Nov 15, 2020

If you want, I can contribute some advanced CI to your repository in a PR. Let me know if you want that.

@sampsyo
Copy link
Owner

sampsyo commented Nov 15, 2020

Hi! Can you clarify what you would consider setting up? We don't have any tests for this component…

@KTibow
Copy link
Contributor Author

KTibow commented Nov 15, 2020

I can contribute hassfest and HACS validation, the recognized combo by HACS, and I can add flake8 to your preferences if you want. I can also contribute optional auto-formatting that amends to the last commit.

@sampsyo
Copy link
Owner

sampsyo commented Nov 15, 2020

Neat; that seems cool! Thanks for offering! I think flake8 would be great, but we can probably do without the auto-formatter, at least for now. 🙏

@KTibow
Copy link
Contributor Author

KTibow commented Nov 15, 2020

Packaged or independent? I made a combined GH action, but it's totally optional, however it means that it will constantly get better.

@sampsyo
Copy link
Owner

sampsyo commented Nov 15, 2020

Cool! Let's try your combined GH action and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants